Remove COBALT_MEDIA_ENABLE_SIDE_DATA

Chromium m114 has same side_data() as in old Cobalt. We can simply
remove COBALT_MEDIA_ENABLE_SIDE_DATA to enable hdr10+.

b/375059645

Author: jasonzhangxx

media/starboard/BUILD.gn

@@ -39,9 +39,6 @@ source_set("starboard") {
     # TODO(b/326654546): Revisit max video input size
     "COBALT_MEDIA_ENABLE_PLAYER_SET_MAX_VIDEO_INPUT_SIZE=0",
 
-    # TODO(b/375059645): Revisit side data (aka hdr10+) support
-    "COBALT_MEDIA_ENABLE_SIDE_DATA=0",
-
     # TODO(b/375234428): Revisit startup latency tracking
     "COBALT_MEDIA_ENABLE_STARTUP_LATENCY_TRACKING=0",
 

media/starboard/sbplayer_bridge.cc

@@ -940,18 +940,15 @@ void SbPlayerBridge::WriteBuffersInternal(
 
     gathered_sbplayer_sample_infos_side_data.push_back(
         SbPlayerSampleSideData());
-#if COBALT_MEDIA_ENABLE_SIDE_DATA
     SbPlayerSampleSideData* side_data =
         &gathered_sbplayer_sample_infos_side_data[i];
-#endif  // COBALT_MEDIA_ENABLE_SIDE_DATA
 
     PlayerSampleInfo sample_info = {};
     sample_info.type = sample_type;
     sample_info.buffer = buffer->data();
     sample_info.buffer_size = buffer->data_size();
     sample_info.timestamp = buffer->timestamp().InMicroseconds();
 
-#if COBALT_MEDIA_ENABLE_SIDE_DATA
     if (buffer->side_data_size() > 0) {
       // We only support at most one side data currently.
       side_data->type = kMatroskaBlockAdditional;
@@ -960,7 +957,6 @@ void SbPlayerBridge::WriteBuffersInternal(
       sample_info.side_data = side_data;
       sample_info.side_data_count = 1;
     }
-#endif  // COBALT_MEDIA_ENABLE_SIDE_DATA
 
     if (sample_type == kSbMediaTypeAudio) {
       DCHECK(audio_stream_info);