Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solar Mass value is 'too precise' #144

Open
JBorrow opened this issue Mar 9, 2020 · 2 comments
Open

Solar Mass value is 'too precise' #144

JBorrow opened this issue Mar 9, 2020 · 2 comments

Comments

@JBorrow
Copy link
Contributor

JBorrow commented Mar 9, 2020

The solar mass equivalence value:

unyt/unyt/_physical_ratios.py

Line 22 in 711e2eb

mass_sun_kg = 1.98841586e30

contains too many digits. http://pdg.lbl.gov/2019/reviews/rpp2018-rev-astrophysical-constants.pdf recommends 1.98841e30 kg based on 2019 measurements.
@JBorrow
Copy link
Contributor Author

JBorrow commented Mar 9, 2020

Another possible issue is that the referenced pdf sheet is no longer available.

@ngoldbaum
Copy link
Member

I think this if fine to be updated, personally. I think this may cause some downstream issues in yt though. @jzuhone thoughts?

@neutrinoceros neutrinoceros mentioned this issue Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ngoldbaum @JBorrow