-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support including transitive dependencies #107
Comments
this is a no-go because of the potential inconsistencies with the dependencies. for example, if the gallery-c changes, and it stops depending on gallery-d, then you ended up in a situation where: a) you have to updates all the affected gallery modules on every gallery push now, the solution that we are recommending for this kind of stuff is to expand metadata per app, rather than doing it at the library or gallery level. |
@caridy What tool would that be? |
we are working on an app-level tool that will help you to generate the loader config using |
Looking forward to it. :) |
When building gallery modules, it would be neat if shifter could augment the "requires" list with transitive dependencies within the gallery. So if gallery-a depends on gallery-b, and gallery-b depends on gallery-c and gallery-d, then gallery-a would list all three modules.
The big reason for this is that it would reduce the number of request to the gallery and make pages load faster. Instead of 3 requests (gallery-a, then gallery-b, then gallery-c and gallery-d), it would only requires 2 requests (gallery-a, then gallery-b, gallery-c, and gallery-d). The deeper the dependency tree, the bigger the savings.
The text was updated successfully, but these errors were encountered: