-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inside HTML chunks, some javascript syntax highlighting rules still apply #1
Comments
Ping |
I'm seeing this too. No idea how to fix it though. :( |
10980f0 fixes the common case where quotes surrounded by letters are interpreted as strings:
Unfortunately, syntax highlighting uses regular expressions for speed reasons, and JavaScript (including JSX) are not regular languages. (Still, we can probably do better, but not without significantly refactoring the language file.) To work around this at Facebook (when it comes up), we've been using expression interpolation:
Kind of lame, but not the end of the world. I hope this helps, and I welcome any PRs that attempt to provide a better solution. |
It's working! Thank you! |
Seems like js parsing rules are still applying inside html chunks, which makes writing html really hard. I've highlighted a few issues below:
The text was updated successfully, but these errors were encountered: