Skip to content

Commit 9459685

Browse files
authored
Merge pull request #13 from yusufk/react18
Trying an improved deploy action
2 parents dc85ae6 + 61ad577 commit 9459685

File tree

3 files changed

+43
-66
lines changed

3 files changed

+43
-66
lines changed

.github/workflows/deploy.yml

Lines changed: 31 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,26 @@ name: Deploy to GitHub Pages
33
on:
44
push:
55
branches:
6-
- master # or the branch you want to deploy from
6+
- master
77
pull_request:
88
types:
99
- closed
1010
branches:
1111
- master
1212

13+
concurrency:
14+
group: "pages"
15+
cancel-in-progress: false
16+
1317
jobs:
1418
build:
15-
# Only run if PR was merged
16-
if: github.event.pull_request.merged == true
19+
# Modified condition to handle both direct pushes and merged PRs
20+
if: github.event_name == 'push' || github.event.pull_request.merged == true
1721
runs-on: ubuntu-latest
1822

1923
steps:
2024
- name: Checkout code
21-
uses: actions/checkout@v2
25+
uses: actions/checkout@v4
2226

2327
- name: Generate index files
2428
run: |
@@ -33,18 +37,35 @@ jobs:
3337
done
3438
3539
- name: Set up Node.js
36-
uses: actions/setup-node@v2
40+
uses: actions/setup-node@v4
3741
with:
3842
node-version: '18'
43+
cache: 'npm' # Add caching for faster installations
44+
45+
- name: Setup Pages
46+
uses: actions/configure-pages@v5
3947

4048
- name: Install dependencies
41-
run: npm install
49+
run: npm ci # Use ci instead of install for cleaner, more reliable builds
4250

4351
- name: Build project
4452
run: npm run build
4553

46-
- name: Deploy to GitHub Pages
47-
uses: peaceiris/actions-gh-pages@v3
54+
- name: Upload artifact
55+
uses: actions/upload-pages-artifact@v3
4856
with:
49-
github_token: ${{ secrets.GITHUB_TOKEN }}
50-
publish_dir: ./build
57+
path: ./out
58+
59+
deploy:
60+
environment:
61+
name: github-pages
62+
url: ${{ steps.deployment.outputs.page_url }}
63+
runs-on: ubuntu-latest
64+
needs: build
65+
permissions:
66+
pages: write
67+
id-token: write
68+
steps:
69+
- name: Deploy to GitHub Pages
70+
id: deployment
71+
uses: actions/deploy-pages@v4

src/components/about.jsx

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -60,61 +60,6 @@ export default class About extends Component {
6060
</div>
6161
</div>
6262
{/* End About Me */}
63-
{/* ======= Counts ======= */}
64-
{/*
65-
<div className="counts container">
66-
<div className="row">
67-
<div className="col-lg-3 col-md-6">
68-
<div className="count-box">
69-
<i className="bi bi-emoji-smile" />
70-
<span
71-
data-purecounter-start={0}
72-
data-purecounter-end={232}
73-
data-purecounter-duration={1}
74-
className="purecounter"
75-
/>
76-
<p>Happy Clients</p>
77-
</div>
78-
</div>
79-
<div className="col-lg-3 col-md-6 mt-5 mt-md-0">
80-
<div className="count-box">
81-
<i className="bi bi-journal-richtext" />
82-
<span
83-
data-purecounter-start={0}
84-
data-purecounter-end={521}
85-
data-purecounter-duration={1}
86-
className="purecounter"
87-
/>
88-
<p>Projects</p>
89-
</div>
90-
</div>
91-
<div className="col-lg-3 col-md-6 mt-5 mt-lg-0">
92-
<div className="count-box">
93-
<i className="bi bi-headset" />
94-
<span
95-
data-purecounter-start={0}
96-
data-purecounter-end={1463}
97-
data-purecounter-duration={1}
98-
className="purecounter"
99-
/>
100-
<p>Hours Of Support</p>
101-
</div>
102-
</div>
103-
<div className="col-lg-3 col-md-6 mt-5 mt-lg-0">
104-
<div className="count-box">
105-
<i className="bi bi-award" />
106-
<span
107-
data-purecounter-start={0}
108-
data-purecounter-end={24}
109-
data-purecounter-duration={1}
110-
className="purecounter"
111-
/>
112-
<p>Awards</p>
113-
</div>
114-
</div>
115-
</div>
116-
</div>
117-
{/* End Counts */}
11863
{/* ======= Skills ======= */}
11964
<div className="skills container">
12065
<div className="section-title">

src/components/header.jsx

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,18 @@ export default class Header extends Component {
1313
<h2>
1414
I'm a passionate&nbsp;
1515
<div className="ms-slider">
16-
{/* slider content */}
16+
<ul className="ms-slider__words">
17+
<li className="ms-slider__word">Engineer</li>
18+
<li className="ms-slider__word">Husband</li>
19+
<li className="ms-slider__word">Product Manager</li>
20+
<li className="ms-slider__word">Wanderer</li>
21+
<li className="ms-slider__word">Father</li>
22+
<li className="ms-slider__word">Mountain Biker</li>
23+
<li className="ms-slider__word">Tinkerer</li>
24+
<li className="ms-slider__word">Muslim</li>
25+
<li className="ms-slider__word">Technologist</li>
26+
<li className="ms-slider__word">Engineer</li>
27+
</ul>
1728
</div>
1829
</h2>
1930
<nav id="navbar" className="navbar">

0 commit comments

Comments
 (0)