Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster could check if specified AMI ID is valid #110

Closed
a1exsh opened this issue May 16, 2017 · 1 comment
Closed

Update cluster could check if specified AMI ID is valid #110

a1exsh opened this issue May 16, 2017 · 1 comment

Comments

@a1exsh
Copy link
Collaborator

a1exsh commented May 16, 2017

Currently it will happily terminate the node to find out later that it cannot start a replacement:

  File "/home/oshulgin/src/planb-cassandra/planb/update_cluster.py", line 202, in build_run_instances_params
    image = ec2.describe_images(ImageIds=[params['ImageId']])['Images'][0]
  File "/home/oshulgin/.local/lib/python3.5/site-packages/botocore/client.py", line 253, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/home/oshulgin/.local/lib/python3.5/site-packages/botocore/client.py", line 557, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidAMIID.NotFound) when calling the DescribeImages operation: The image id '[ami-0123xxx]' does not exist

Probably we should also fail early if docker image we try to update with cannot be found.

@a1exsh
Copy link
Collaborator Author

a1exsh commented Mar 12, 2020

Duplicate of #183

@a1exsh a1exsh marked this as a duplicate of #183 Mar 12, 2020
@a1exsh a1exsh closed this as completed Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant