Merge pull request #927 from zalando/ARUHA-1681-fixnpe

antban · web-flow · commit 53df492bcfda · 2018-08-02T17:07:58.000+03:00
ARUHA-1681 Fix npe while committing cursors
diff --git a/src/main/java/org/zalando/nakadi/service/AuthorizationValidator.java b/src/main/java/org/zalando/nakadi/service/AuthorizationValidator.java
@@ -184,6 +184,9 @@ public void authorizeSubscriptionRead(final Subscription subscription) throws Ac
     }
 
     public void authorizeSubscriptionCommit(final Subscription subscription) throws AccessDeniedException {
+        if (null == subscription.getAuthorization()) {
+            return;
+        }
         final Resource resource = subscription.asResource();
         try {
             if (!authorizationService.isAuthorized(AuthorizationService.Operation.READ, resource)

Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,9 @@ public void authorizeSubscriptionRead(final Subscription subscription) throws Ac`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`public void authorizeSubscriptionCommit(final Subscription subscription) throws AccessDeniedException {`
	`187`	`+ if (null == subscription.getAuthorization()) {`
	`188`	`+ return;`
	`189`	`+ }`
`187`	`190`	`final Resource resource = subscription.asResource();`
`188`	`191`	`try {`
`189`	`192`	`if (!authorizationService.isAuthorized(AuthorizationService.Operation.READ, resource)`