Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align skipper OPA config for max request body size with OPA config #3177

Open
Pushpalanka opened this issue Jul 30, 2024 · 0 comments
Open
Assignees

Comments

@Pushpalanka
Copy link
Collaborator

Pushpalanka commented Jul 30, 2024

Describe the improvement
As of now Skipper OPA integration has a skipper specific configuration open-policy-agent-max-request-body-size to govern the max allowed request body parsing limit to safeguard against out of memory issues.

With 0.67.0 release of OPA, they have inbuilt this safeguard into OPA configuration using the below keys:

# Set max request size to 64 MB and max gzip size (decompressed) to be 128 MB.
server:
  decoding:
    max_length: 67108864
    gzip:
      max_length: 134217728

To avoid confusions on the limit based on the two configs, it's best to align them in the integration.

Expected behavior
The value set in open-policy-agent-max-request-body-size configuration in Skipper is passed to OPA, as understood by it's configs. This will make sure same config values are honored in both levels avoiding confusions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant