Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is react, inferno-compat included? #1

Open
unreadable opened this issue Mar 13, 2017 · 3 comments
Open

Why is react, inferno-compat included? #1

unreadable opened this issue Mar 13, 2017 · 3 comments

Comments

@unreadable
Copy link

unreadable commented Mar 13, 2017

I've been reading through the files of this project and seems to be a pretty good implementation excepting one thing, this module seems to be based on react and inferno-compat which decreases the performance inferno offers..I'm pretty sure it can be updated using inferno and inferno-component instead of parts from react or inferno-compat modules. Is there any plans to make changes? I could submit a pull request and throw a look on it if needed, other than that well done with the module!

@zanettin
Copy link
Owner

hi @krypton97
great you ask! i was a bit in hurry while i created this port and took the fasted way to get it up and running. if you have the time to create a pr i really appreciate it. dont have much time right now unfortunately 😢

@unreadable
Copy link
Author

Sure, I'll make a pr as soon as I finish to update it ;)

@zanettin
Copy link
Owner

very nice and thx a lot in advance @krypton97 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants