Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new "Event.parents" property #3

Open
zchn opened this issue Feb 12, 2025 · 2 comments
Open

Implement new "Event.parents" property #3

zchn opened this issue Feb 12, 2025 · 2 comments

Comments

@zchn
Copy link
Owner

zchn commented Feb 12, 2025

What problem or use case are you trying to solve?
In the EventStream, subscribers process any new Event objects and emit new Event objects according.

Currently, Event objects in an EventStream contain no information about what parent Event objects this Event is a result of, making it hard to figure out the provenance information about an Event.

We want to add a parents property to the Event object (class definition in openhands/events/event.py) to carry such provenance information.

Do you have thoughts on the technical implementation?

  1. In the Event class in openhands/events/event.py, a new parents property should be added, and it should be a list of ParentEvent objects with two properties: id: int and method: str. The id property records the id of the parent event, and the method property records what kind of processing was done to derive the new event from the parent event.
  2. Whenever a new event is created (typically when EventStream.add_event is called), it should add parent information to the newly created event, based on the existing event received and being processed.

Additional context

  1. Implement appropriate tests.
  2. Make sure to run applicable unit tests and lint tests to make sure they all pass.
@zchn zchn added enhancement New feature or request fix-me-experimental and removed enhancement New feature or request labels Feb 12, 2025
@zchn
Copy link
Owner Author

zchn commented Feb 12, 2025

OpenHands started fixing the issue! You can monitor the progress here.

@zchn
Copy link
Owner Author

zchn commented Feb 12, 2025

OpenHands started fixing the issue! You can monitor the progress here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant