-
Notifications
You must be signed in to change notification settings - Fork 1
/
overlook.cmake
504 lines (443 loc) · 22.3 KB
/
overlook.cmake
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
###############################################################
#
# Overlook: a cmake plugin for safer c/c++ programming.
#
# Author: Zhuo Zhang <imzhuo@foxmail.com>
# Homepage: https://github.com/zchrissirhcz/rocbuild
#
###############################################################
cmake_minimum_required(VERSION 3.20)
include_guard()
set(OVERLOOK "${CMAKE_CURRENT_LIST_FILE}")
set(OVERLOOK_VERSION "2024.06.12")
option(OVERLOOK_GLOBAL "Apply overlook globally?" ON)
set(OVERLOOK_C_COMPILE_OPTIONS)
set(OVERLOOK_CXX_COMPILE_OPTIONS)
# Print overlook information
message("----------------------------------------------------------")
message(" Overlook: a cmake tool for safer C/C++ programming ")
message(" Author : Zhuo Zhang (imzhuo@foxmail.com) ")
message(" Homepage: https://github.com/zchrissirhcz/rocbuild ")
message(" Version : ${OVERLOOK_VERSION} ")
message("----------------------------------------------------------")
if(CMAKE_C_COMPILER_ID)
set(OVERLOOK_WITH_C TRUE)
else()
set(OVERLOOK_WITH_C FALSE)
endif()
if(CMAKE_CXX_COMPILER_ID)
set(OVERLOOK_WITH_CXX TRUE)
else()
set(OVERLOOK_WITH_CXX FALSE)
endif()
# Project LANGUAGE not including C and CXX so we return
if((NOT OVERLOOK_WITH_C) AND (NOT OVERLOOK_WITH_CXX))
overlook_warn("Neither C nor CXX compiler available. No OVERLOOK C/C++ flags will be set")
overlook_warn("You may specify C and CXX in `project()` command")
return()
endif()
# rule0: don't ignore all that warnings
# If `-w` specified for GCC/Clang, report an error
if((CMAKE_C_COMPILER_ID MATCHES "GNU") OR (CMAKE_C_COMPILER_ID MATCHES "Clang"))
get_directory_property(overlook_detected_global_compile_options COMPILE_OPTIONS)
message("Detected Global Compile Options: ${overlook_detected_global_compile_options}")
string(REGEX MATCH "-w" ignore_all_warnings "${overlook_detected_global_compile_options}" )
if(ignore_all_warnings)
overlook_error("Found `-w` compile options, it ignore all warnings. Please remove it (in `add_compile_options)`")
endif()
endif()
#--------------------------------------------------------------------------------
# Function return value related
#--------------------------------------------------------------------------------
# rule1: calls a function when it is not declared. C compiler doesn't treat it an error, but we do.
# 函数没有声明就使用, C编译器默认不报错，改为强制报错
# 解决bug: 地址截断; 内存泄漏
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4013)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4013)
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=implicit-function-declaration)
if(CMAKE_CXX_COMPILER_VERSION LESS 9.1)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=implicit-function-declaration)
endif()
if(CMAKE_C_COMPILER_VERSION GREATER_EQUAL 11.1)
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=builtin-declaration-mismatch)
endif()
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=implicit-function-declaration)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=implicit-function-declaration)
endif()
# rule2: 函数虽然有声明，但是声明不完整，没有写出返回值类型，C编译器默认不报错，改为强制报错
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4431)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4431)
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=implicit-int)
if(CMAKE_CXX_COMPILER_VERSION LESS 9.1)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=implicit-int)
endif()
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=implicit-int)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=implicit-int)
endif()
# rule4: when missing return value for non-void function, C/C++ compiler treat it as UB and not report error, we treat it as error.
# it may cause crash, or just return un-expected result, depends on the compiler and the code you write
# 函数应该有返回值但没有 return 返回值，或不是所有路径都有返回值，C和C++编译器默认不报错，改为强制报错
# 解决bug: lane detect; vpdt for循环无法跳出(android输出trap); lane calib库读取到随机值导致获取非法格式asvl, 开asan则表现为读取NULL指针
# -O3时输出内容和其他优化等级不一样 (from 三老师)
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4716 /we4715)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4716 /we4715)
else()
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=return-type)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=return-type)
endif()
# rule30: 所有的控件路径(if/else)必须都有返回值
# NDK21 Clang / Linux Clang/GCC/G++ 默认都报 error
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4715)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4715)
endif()
# rule6: 函数不应该返回局部变量的地址
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4172)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4172)
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=return-local-addr)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=return-local-addr)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=return-stack-address)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=return-stack-address)
endif()
#--------------------------------------------------------------------------------
# Function argument/parameter, type conversion/casting related
#--------------------------------------------------------------------------------
# rule12: 函数声明中的参数列表和定义中不一样。在 MSVC C 下为警告, Linux Clang 下报错
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4029)
endif()
# rule13: 实参太多, 比函数定义或声明中的要多。只在MSVC C 下为警告, Linux Clang下报错
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4020)
endif()
# rule14: 避免 void* 类型的指针参参与算术运算
# MSVC C/C++ 默认会报错, Linux gcc 不报 warning 和 error, Linux g++ 只报 warning
# Linux 下 Clang 开 -Wpedentric 才报 warning, Clang++ 报 error
if(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=pointer-arith)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=pointer-arith)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=pointer-arith)
endif()
# rule3: 指针类型不兼容，C编译器默认不报错，改为强制报错
# 解决bug: crash或结果异常
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4133)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4133)
elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
if(CMAKE_CXX_COMPILER_VERSION GREATER 4.8) # gcc/g++ 4.8.3 not ok
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=incompatible-pointer-types)
if(CMAKE_CXX_COMPILER_VERSION LESS 9.1)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=incompatible-pointer-types)
endif()
endif()
elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=incompatible-pointer-types)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=incompatible-pointer-types)
endif()
# rule10: 避免把 int 指针赋值给 int 类型变量
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4047)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4047)
elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
if(CMAKE_CXX_COMPILER_VERSION GREATER 4.8)
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=int-conversion)
if(CMAKE_CXX_COMPILER_VERSION LESS 9.1)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=int-conversion)
endif()
endif()
elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=int-conversion)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=int-conversion)
endif()
# rule8: printf 等语句中的格式串和实参类型不匹配，要避免
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4477)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4477)
else()
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=format)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=format)
endif()
# rule17: 形参与声明不同。场景：静态库(.h/.c)，集成时换库但没换头文件，且函数形参有变化（类型或数量）
# 只报 warning 不报 error。仅 VS 出现
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4028)
endif()
# rule21: “类型强制转换”: 例如从 int 转换到更大的 void*
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4312)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4312)
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=int-to-pointer-cast)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=int-to-pointer-cast)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=int-to-pointer-cast)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=int-to-pointer-cast)
endif()
# rule23: 类函数宏的调用 参数过多
# VC/VC++ 报警告。Linux 下的 GCC/Clang 报 error
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4002)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4002)
endif()
# rule24: 类函数宏的调用 参数不足
# VC/VC++ 同时会报 error C2059
# Linux GCC/Clang 直接报错
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4003)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4003)
endif()
#--------------------------------------------------------------------------------
# Initialization, memory release related
#--------------------------------------------------------------------------------
# rule7: 变量没初始化就使用，要避免
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4700 /we26495)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4700 /we26495)
else()
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=uninitialized)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=uninitialized)
endif()
# rule11: 检查数组下标越界访问
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we6201 /we6386 /we4789)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we6201 /we6386 /we4789)
else()
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=array-bounds)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=array-bounds)
endif()
# rule16: 释放非堆内存
# TODO: 检查 MSVC
# Linux Clang8.0 无法检测到
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=free-nonheap-object)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=free-nonheap-object)
endif()
# rule32: 用 memset 等 C 函数设置 非 POD class 对象
# Linux下, GCC9.3 能发现此问题, 但clang10 不能发现
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
if(CMAKE_CXX_COMPILER_VERSION GREATER 7.5)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=class-memaccess)
endif()
endif()
# rule15: 避免符号重复定义（变量对应的强弱符号）。只在 C 中出现。
# 暂时没找到 MSVC 的对应编译选项
if(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -fno-common)
endif()
#--------------------------------------------------------------------------------
# Pre-compilation directive related
#--------------------------------------------------------------------------------
# rule18: 宏定义重复
# gcc5~gcc9 无法检查
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4005)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4005)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=macro-redefined)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=macro-redefined)
endif()
# rule19: pragma init_seg 指定了非法(不能识别的)section名字
# VC++ 特有。Linux 下的 gcc/clang 没有
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4075)
endif()
# rule25: #undef 没有跟一个标识符
# Linux GCC/Clang 直接报错
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4006)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4006)
endif()
#--------------------------------------------------------------------------------
# Unused stuffs related
#--------------------------------------------------------------------------------
# rule27: 没有使用到表达式结果（无用代码行，应删除）
# 感觉容易被误伤，可以考虑关掉
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4552 /we4555)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4552 /we4555)
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=unused-value)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=unused-value)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=unused-value)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=unused-value)
endif()
# rule28: “==”: 未使用表达式结果；是否打算使用“=”?
# Linux GCC 没有对应的编译选项
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4553)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4553)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=unused-comparison)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=unused-comparison)
endif()
# 可能会导致下一行代码报错，而问题根源在包含继续符的这行注释
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4006)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4006)
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=comment)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=comment)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=comment)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=comment)
endif()
#--------------------------------------------------------------------------------
# String/Char related
#--------------------------------------------------------------------------------
# rule22: 不可识别的字符转义序列
# GCC5.4 能显示 warning 但无别名，因而无法视为 error
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4129)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4129)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=unknown-escape-sequence)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=unknown-escape-sequence)
endif()
# rule29: C++中，禁止把字符串常量赋值给 char* 变量
# VS2019 开启 /Wall 后也查不到
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=write-strings)
elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
# Linux Clang 和 AppleClang 不太一样
if(CMAKE_SYSTEM_NAME MATCHES "Linux")
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=writable-strings)
elseif(CMAKE_SYSTEM_NAME MATCHES "Darwin")
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=c++11-compat-deprecated-writable-strings)
endif()
endif()
# rule31: multi-char constant
# MSVC 没有对应的选项
if(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=multichar)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=multichar)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=multichar)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=multichar)
endif()
#--------------------------------------------------------------------------------
# Type safe related
#--------------------------------------------------------------------------------
# rule9: 避免把 unsigned int 和 int 直接比较
# 通常会误伤，例如 for 循环中。可以考虑关掉
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4018)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4018)
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=sign-compare)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=sign-compare)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=sign-compare)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=sign-compare)
endif()
# rule20: size_t 类型被转为更窄类型
# VC/VC++ 特有。 Linux 下的 gcc/clang 没有
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4267)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4267)
endif()
## rule34: double 型转 float 型，可能有精度丢失（尤其在 float 较大时）
# MSVC 默认是放在 /W3
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we4244)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we4244)
endif()
## rule37: float 转换隐式转换为 int，可能改变变量的值
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=float-conversion)
elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=float-conversion)
endif()
#--------------------------------------------------------------------------------
# Misc
#--------------------------------------------------------------------------------
## rule33: 括号里面是单个等号而不是双等号
# Linux Clang14 可以发现问题，但 GCC9.3 无法发现; android clang 可以发现
if(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=parentheses)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=parentheses)
endif()
## rule35: 父类有 virtual 的成员函数，但析构函数是 public 并且不是 virtual, 会导致 UB
# https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c35-a-base-class-destructor-should-be-either-public-and-virtual-or-protected-and-non-virtual
# -Wnon-virtual-dtor (C++ and Objective-C++ only)
# Warn when a class has virtual functions and an accessible non-virtual destructor itself or in an accessible polymorphic base
# class, in which case it is possible but unsafe to delete an instance of a derived class through a pointer to the class
# itself or base class. This warning is automatically enabled if -Weffc++ is specified.
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=non-virtual-dtor)
elseif(CMAKE_C_COMPILER_ID MATCHES "Clang")
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=non-virtual-dtor)
endif()
## rule36: switch case 忘记写 break, 会 fallthrough 执行， 可能导致数组越界(具体取决于你的代码). 不写break我们视为错误。
if((CMAKE_C_COMPILER_ID MATCHES "GNU") OR (CMAKE_CXX_COMPILER_ID MATCHES "GNU"))
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=implicit-fallthrough)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=implicit-fallthrough)
elseif((CMAKE_C_COMPILER_ID MATCHES "Clang") OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang"))
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=implicit-fallthrough)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=implicit-fallthrough)
endif()
# rule5: 避免使用影子(shadow)变量
# 有时候会误伤, 例如eigen等开源项目, 可以手动关掉
if(CMAKE_C_COMPILER_ID STREQUAL "MSVC")
list(APPEND OVERLOOK_C_COMPILE_OPTIONS /we6244 /we6246 /we4457 /we4456)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS /we6244 /we6246 /we4457 /we4456)
else()
list(APPEND OVERLOOK_C_COMPILE_OPTIONS -Werror=shadow)
list(APPEND OVERLOOK_CXX_COMPILE_OPTIONS -Werror=shadow)
endif()
# 将上述定制的 FLAGS 追加到 CMAKE 默认的编译选项中
# 为什么是添加而不是直接设定呢？因为 xxx-toolchain.cmake 中可能会设置一些默认值 (如 Android NDK), 需要避免这些默认值被覆盖
string(REPLACE ";" " " OVERLOOK_C_FLAGS "${OVERLOOK_C_COMPILE_OPTIONS}")
string(REPLACE ";" " " OVERLOOK_CXX_FLAGS "${OVERLOOK_CXX_COMPILE_OPTIONS}")
if(OVERLOOK_GLOBAL)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OVERLOOK_C_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OVERLOOK_CXX_FLAGS}")
else()
add_library(overlook INTERFACE)
target_compile_options(overlook INTERFACE $<$<COMPILE_LANGUAGE:C>:${OVERLOOK_C_COMPILE_OPTIONS}>)
target_compile_options(overlook INTERFACE $<$<COMPILE_LANGUAGE:CXX>:${OVERLOOK_CXX_COMPILE_OPTIONS}>)
endif()
unset(OVERLOOK_C_COMPILE_OPTIONS)
unset(OVERLOOK_CXX_COMPILE_OPTIONS)
##################################################################################
# Add whole archive when build static library
# Usage:
# overlook_add_whole_archive_flag(<lib> <output_var>)
# Example:
# add_library(foo foo.hpp foo.cpp)
# add_executable(bar bar.cpp)
# overlook_add_whole_archive_flag(foo safe_foo)
# target_link_libraries(bar ${safe_foo})
##################################################################################
function(overlook_add_whole_archive_flag lib output_var)
if("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
if(MSVC_VERSION GREATER 1900)
set(${output_var} -WHOLEARCHIVE:$<TARGET_FILE:${lib}> PARENT_SCOPE)
else()
overlook_warn("MSVC version is ${MSVC_VERSION}, /WHOLEARCHIVE flag cannot be set")
set(${output_var} ${lib} PARENT_SCOPE)
endif()
elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU")
set(${output_var} -Wl,--whole-archive ${lib} -Wl,--no-whole-archive PARENT_SCOPE)
elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" AND CMAKE_SYSTEM_NAME MATCHES "Linux")
# set(${output_var} -Wl,--whole-archive ${lib} -Wl,--no-whole-archive PARENT_SCOPE)
elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" AND NOT ANDROID)
set(${output_var} -Wl,-force_load ${lib} PARENT_SCOPE)
elseif(ANDROID)
# 即使是 NDK21 并且手动传入 ANDROID_LD=lld, 依然要用ld的查重复符号的链接选项
set(${output_var} -Wl,--whole-archive ${lib} -Wl,--no-whole-archive PARENT_SCOPE)
else()
overlook_error("add_whole_archive_flag not supported yet for current compiler: ${CMAKE_CXX_COMPILER_ID}")
endif()
endfunction()