Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d_a_tag_Lv8Gate OK #2079

Merged
merged 11 commits into from
Feb 28, 2024
Merged

d_a_tag_Lv8Gate OK #2079

merged 11 commits into from
Feb 28, 2024

Conversation

GinNoOokami
Copy link
Collaborator

No description provided.

@Trueffeloot
Copy link
Contributor

Nice job! Just remember to remove the asm ./tp remove-unused-asm and me or somebody else will check your work

@GinNoOokami
Copy link
Collaborator Author

Nice job! Just remember to remove the asm ./tp remove-unused-asm and me or somebody else will check your work

Yep, my bad! I'll try to remember this going forward.

Trueffeloot
Trueffeloot requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@Trueffeloot Trueffeloot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Some minor improvements which I recommend and this can be merged

include/rel/d/a/tag/d_a_tag_Lv8Gate/d_a_tag_Lv8Gate.h Outdated Show resolved Hide resolved
include/rel/d/a/tag/d_a_tag_Lv8Gate/d_a_tag_Lv8Gate.h Outdated Show resolved Hide resolved
rel/d/a/tag/d_a_tag_Lv8Gate/d_a_tag_Lv8Gate.cpp Show resolved Hide resolved
rel/d/a/tag/d_a_tag_Lv8Gate/d_a_tag_Lv8Gate.cpp Show resolved Hide resolved
rel/d/a/tag/d_a_tag_Lv8Gate/d_a_tag_Lv8Gate.cpp Outdated Show resolved Hide resolved
TakaRikka
TakaRikka approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@TakaRikka TakaRikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple small things that can be cleaned up which are good to note for the future

include/rel/d/a/tag/d_a_tag_Lv8Gate/d_a_tag_Lv8Gate.h Outdated Show resolved Hide resolved
rel/d/a/tag/d_a_tag_Lv8Gate/d_a_tag_Lv8Gate.cpp Outdated Show resolved Hide resolved
rel/d/a/tag/d_a_tag_Lv8Gate/d_a_tag_Lv8Gate.cpp Outdated Show resolved Hide resolved
@GinNoOokami
Copy link
Collaborator Author

I don't have write access, so feel free to merge this if everything looks good now.

@TakaRikka TakaRikka merged commit 555e4bc into zeldaret:main Feb 28, 2024
1 check passed
@GinNoOokami GinNoOokami deleted the d_a_tag_Lv8Gate branch February 29, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trueffeloot Trueffeloot Trueffeloot approved these changes

@TakaRikka TakaRikka TakaRikka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GinNoOokami @Trueffeloot @TakaRikka