d_a_tag_statue_evt OK

[marwernerh]

Matching and some documentation

[GinNoOokami]

Don't forget to remove the asms with ./tp remove-unused-asm when completing a file 😺

[GinNoOokami]

Try using cXyz::abs() here instead.

[GinNoOokami]

There's another instance of this in the next function as well. The abs() call should inline to the same thing here, and is likely what was originally used, so give it a try and see if it still matches.

[hatal175]

Merged already. Oh well. Next person gets bonus files :)

…

On Sun, Mar 24, 2024, 19:33 Jeff Padgham ***@***.***> wrote: ***@***.**** commented on this pull request. Don't forget to remove the asms with ./tp remove-unused-asm when completing a file :) ------------------------------ In rel/d/a/tag/d_a_tag_statue_evt/d_a_tag_statue_evt.cpp <#2107 (comment)>: > + Vec statue_tag_xy_pos; + Vec found_owl_statue_xy_pos; + + const f32 found_owl_statue_z = fopAcM_GetPosition(found_owl_statue).z; + const f32 found_owl_statue_x = fopAcM_GetPosition(found_owl_statue).x; + found_owl_statue_xy_pos.x = found_owl_statue_x; + found_owl_statue_xy_pos.y = 0.0f; + found_owl_statue_xy_pos.z = found_owl_statue_z; + + const f32 statue_tag_z = fopAcM_GetPosition(this).z; + const f32 statue_tag_x = fopAcM_GetPosition(this).x; + statue_tag_xy_pos.x = statue_tag_x; + statue_tag_xy_pos.y = 0.0f; + statue_tag_xy_pos.z = statue_tag_z; + + const f32 distance_between_statue_and_tag = sqrtf(PSVECSquareDistance(&found_owl_statue_xy_pos, &statue_tag_xy_pos)); Try using cXyz::abs() here instead. — Reply to this email directly, view it on GitHub <#2107 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACYQXXJKSOZYJUQP56KRJNTYZ4E55AVCNFSM6AAAAABFFG7EGGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWGYYTANRUGA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>