Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation is done getSelectBombPriceLocal 99.77% #2196

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

GermanAizek
Copy link
Contributor

@hatal175, I accidentally found your profile in decomp.me this is a really convenient decompilation service. Post more similar draft for progress to 100% reversing, I'm ready to help you in my free time.

Copy link
Contributor

@hatal175 hatal175 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I'm not the only one working on this project and we post some scratches on either the zelda decompilation discord or Gc/Wii decompilation discord.
With regards to your push, the change seems good but it won't match unless all the functions using that floating point literal are matched.
If you just make the change without removing the ifelse and replace the "tertiary condition issue" comment with "Matches with literals", I'd be happy to merge it.

@GermanAizek
Copy link
Contributor Author

Thank you for your contribution! I'm not the only one working on this project and we post some scratches on either the zelda decompilation discord or Gc/Wii decompilation discord. With regards to your push, the change seems good but it won't match unless all the functions using that floating point literal are matched. If you just make the change without removing the ifelse and replace the "tertiary condition issue" comment with "Matches with literals", I'd be happy to merge it.

Fixed it here: c299760

@hatal175 hatal175 merged commit 8386cef into zeldaret:main Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants