From 7dfb42324d93436fa1b67dccfc08956d4f05245c Mon Sep 17 00:00:00 2001 From: Dmitry Pavlov Date: Sat, 7 Oct 2023 17:00:52 +0300 Subject: [PATCH 1/2] trying not to login to docker in pr builds --- .github/workflows/pr.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 91703f5a..7a587dbd 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -20,11 +20,11 @@ jobs: - name: Build with Maven run: mvn --batch-mode verify - run: mkdir dist && cp cli/target/*.tar.gz dist - - name: Login to Docker Hub - uses: docker/login-action@v3 - with: - username: ${{ secrets.DOCKER_HUB_USER }} - password: ${{ secrets.DOCKER_HUB_TOKEN }} + # - name: Login to Docker Hub + # uses: docker/login-action@v3 + # with: + # username: ${{ secrets.DOCKER_HUB_USER }} + # password: ${{ secrets.DOCKER_HUB_TOKEN }} - name: Set up QEMU uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx From 2ca96ef8e0838320771886f13b4f28dba758f233 Mon Sep 17 00:00:00 2001 From: Dmitry Pavlov Date: Sat, 7 Oct 2023 17:05:21 +0300 Subject: [PATCH 2/2] Removed login procedure when building docker image for pull requests check --- .github/workflows/pr.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 7a587dbd..5e5f3a10 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -20,16 +20,11 @@ jobs: - name: Build with Maven run: mvn --batch-mode verify - run: mkdir dist && cp cli/target/*.tar.gz dist - # - name: Login to Docker Hub - # uses: docker/login-action@v3 - # with: - # username: ${{ secrets.DOCKER_HUB_USER }} - # password: ${{ secrets.DOCKER_HUB_TOKEN }} - name: Set up QEMU uses: docker/setup-qemu-action@v3 - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 - - name: Build and push + - name: Build docker image uses: docker/build-push-action@v5 with: context: ./cli