Skip to content

Commit b9de228

Browse files
committed
Namespace remaining messages, fix tests broken in #9
1 parent 76d3564 commit b9de228

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

lib/client.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ CrossStorageClient.prototype._installListener = function() {
278278
}
279279

280280
// Handle initial connection
281-
if (message.data === 'cross-storage:ready' && !client._connected) {
281+
if (message.data.indexOf('cross-storage:') !== -1 && !client._connected) {
282282
client._connected = true;
283283
if (!client._requests.connect) return;
284284

@@ -381,7 +381,7 @@ CrossStorageClient.prototype._request = function(method, params) {
381381

382382
req = {
383383
id: this._id + ':' + client._count,
384-
method: method,
384+
method: 'cross-storage:' + method,
385385
params: params
386386
};
387387

lib/hub.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ CrossStorageHub._installListener = function() {
6565
* @param {MessageEvent} message A message to be processed
6666
*/
6767
CrossStorageHub._listener = function(message) {
68-
var uri, available, request, error, result, response;
68+
var uri, available, request, method, error, result, response;
6969

7070
// Handle polling for a ready message
7171
if (message.data === 'cross-storage:poll') {
@@ -74,13 +74,17 @@ CrossStorageHub._listener = function(message) {
7474

7575
// Ignore the ready message when viewing the hub directly
7676
if (message.data === 'cross-storage:ready') return;
77+
7778
request = JSON.parse(message.data);
79+
method = request.method.split('cross-storage:')[1];
7880

79-
if (!CrossStorageHub._permitted(message.origin, request.method)) {
80-
error = 'Invalid permissions for ' + request.method;
81+
if (!method) {
82+
return;
83+
} else if (!CrossStorageHub._permitted(message.origin, method)) {
84+
error = 'Invalid permissions for ' + method;
8185
} else {
8286
try {
83-
result = CrossStorageHub['_' + request.method](request.params);
87+
result = CrossStorageHub['_' + method](request.params);
8488
} catch (err) {
8589
error = err.message;
8690
}

test/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('CrossStorageClient', function() {
2121
before(function(done) {
2222
var invoked = false;
2323
var next = function(msg) {
24-
if (msg.data !== 'ready' || invoked) return;
24+
if (msg.data !== 'cross-storage:ready' || invoked) return;
2525
invoked = true;
2626
done();
2727
};

0 commit comments

Comments
 (0)