Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null column include filter doesn't seem to work, excludes all values #2110

Open
sbracegirdle opened this issue Sep 18, 2024 · 1 comment
Open

Comments

@sbracegirdle
Copy link

Hi there, I have a filter rule that is effectively this:

exclude: *.*, include: mydb.User, include: mydb.Entity.someColumn=null

The User changes come through perfectly, but the entity data does not, regardless of someColumn value. I also tried alternative patterns like "null" and /^null$/ to no avail.

But reading the source code for filtering, it does look like there's some logic to handle null values when the pattern is null (https://github.com/zendesk/maxwell/blob/master/src/main/java/com/zendesk/maxwell/filtering/FilterColumnPattern.java)? Have I misinterpreted how it works, or is there an issue? I'm using the zendesk/maxwell:latest container.

If I can get it working I'd be happy to PR a docs change to add examples for null filtering.

@osheroff
Copy link
Collaborator

I tried the most obvious case (exclude: *.*, include: test.foo.a=null) and it seemed to work properly... can you put together a script or a test that repros the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants