Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize go:embed for Embedding Static Assets #8

Open
arham09 opened this issue May 4, 2024 · 0 comments
Open

Utilize go:embed for Embedding Static Assets #8

arham09 opened this issue May 4, 2024 · 0 comments

Comments

@arham09
Copy link

arham09 commented May 4, 2024

Currently, cloudshell directly reading files for static files in public and node_modules from project directory for embedding static assets.

I think we should use go:embed to embed static assets directly into the Go binary. This feature of go will make the distribution of the binary easier, since we dont need to access the static files from the project directory, the downside is the binary will be bigger since it will have node_modules in it, but I think it's worth because we dont need to clone the whole project to use cloudshell, just the released binary is enough.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant