project: Add origin remote
#546
Conversation
Git submodules with relative paths fail to update when repository does not contain `origin` remote. This commit makes sure `origin` remote exists.
Mierunski
force-pushed
the
relative_submodules
branch
from
5e6f433
to
2c6626f
Compare
| # Git submodules that use relative paths resolve them based | ||
| # on `origin` remote, make sure we have it | ||
| try: | ||
| project.git(f'remote get-url -- origin') |
There was a problem hiding this comment.
This would not have helped in the case of sof.
Cause with Zephyr, the sof repo here:
https://github.com/zephyrproject-rtos/sof/
is a fork of:
https://github.com/thesofproject/sof
but the rimage repo has not been forked:
https://github.com/zephyrproject-rtos/rimage/
so even configuring a origin remote would not help in this case.
If users want to combine west and git submodules I think it is fair to set a requirement that all submodules must use real urls and not relative paths.
There was a problem hiding this comment.
but the rimage repo has not been forked:
That's because Zephyr CI does not need rimage, at least not yet.
I'm pretty sure Zephyr has a requirement that all the code in the default, public west.yml manifest must come from a https://github.com/zephyrproject-rtos/ copy to make sure upstream projects don't come and go and maybe for other reasons. I doubt git submodules create an allowed "loophole", do they?
There was a problem hiding this comment.
I doubt git submodules create an allowed "loophole", do they?
I don't think so, but that's not the main point.
Please see here for elaborated reason on why this is bad: #545 (comment)
Git submodules with relative paths fail to update when repository
does not contain
originremote. This commit addsoriginremoteass addition to current remotes.
fixes #545