Always decode manifests with utf-8; not just most of the time #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmetic fix, no functional change. A little less duplication and hardcoding. listdir_at() had an optional "encoding" parameter but it was never used before now, always defaulting to 'utf-8'. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
No functional change: just a lot less duplication & hardcoding. This can help testing and supporting other encodings. It does not hurt in any case. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
It test success in the case(project.py: Specify the manifest file to use UTF-8 encoding #710). |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Fixes issue reported in PR zephyrproject-rtos#710 where most places are hardcoded to 'utf-8' while this one is (Windows) locale-dependent. In the future, we may want to make this more flexible but the most urgent fix is consistency: with this commit, manifest decoding should be hardcoded to 'utf-8' everywhere. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
carlescufi
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits.
This is a "larger" alternative to #710