remove some TODOs

Author: zerosnake0

encoder.go

@@ -340,7 +340,7 @@ func (enc *Encoder) createEncoderInternal(cache, internalCache encoderCache, typ
 				cache[rType] = &directEncoder{x.encoder}
 			}
 		case *mapEncoderBuilder:
-			// TODO: key/value encoder
+			// TODO: key encoder
 			x.encoder.elemEncoder = internalCache[x.elemRType]
 			cache[rType] = &directEncoder{x.encoder}
 		case *sliceEncoderBuilder:

iterator.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"fmt"
 	"io"
+	"runtime"
 )
 
 // for fast reset
@@ -129,7 +130,6 @@ func (it *Iterator) readMore() error {
 		n   int
 		err error
 	)
-	// TODO: risk of infinite loop?
 	for {
 		if it.capture {
 			var buf [bufferSize]byte
@@ -156,6 +156,9 @@ func (it *Iterator) readMore() error {
 		if n > 0 {
 			return nil
 		}
+		// n == 0 && err == nil
+		// the implementation of the reader is wrong
+		runtime.Gosched()
 	}
 }
 

link_reflect.go

@@ -56,7 +56,6 @@ func mapiternext(it *hiter)
 
 func unsafeMakeSlice(elemRType rtype, length, cap int) unsafe.Pointer {
 	return unsafe.Pointer(&sliceHeader{
-		// TODO: is this safe?
 		Data: uintptr(unsafe_NewArray(elemRType, cap)),
 		Len:  length,
 		Cap:  cap,

streamer.go

@@ -47,8 +47,6 @@ func (s *Streamer) Flush() error {
 	// see comment of io.Writer
 	n, err := s.writer.Write(s.buffer)
 	if n < l {
-		// TODO: shall we accept the writers which
-		// TODO: do not implement Write method correctly?
 		copy(s.buffer, s.buffer[n:])
 		s.buffer = s.buffer[:l-n]
 	} else {

struct.go

@@ -169,7 +169,6 @@ func describeStruct(st reflect.Type, tagKey string, onlyTaggedField bool) struct
 						}
 					}
 
-					// TODO: field name for encoder
 					fields = append(fields, field)
 					if count[f.typ] > 1 {
 						/* when we arrived here, we are inside a level, where there are at least

val_decoder_native.go

@@ -87,7 +87,6 @@ func (*stringDecoder) Decode(ptr unsafe.Pointer, it *Iterator, opts *DecOpts) er
 		}
 		l := len(s)
 		if l < 2 {
-			// TODO: custom error
 			return BadQuotedStringError(s)
 		}
 		switch s[0] {

val_encoder.go

@@ -119,7 +119,6 @@ type ValEncoder interface {
 type notSupportedEncoder string
 
 func (enc notSupportedEncoder) IsEmpty(ptr unsafe.Pointer) bool {
-	// TODO: error in interface?
 	return false
 }
 

val_encoder_json_number.go

@@ -20,6 +20,6 @@ func (*jsonNumberEncoder) Encode(ptr unsafe.Pointer, s *Streamer, opts *EncOpts)
 	if str == "" {
 		str = "0"
 	}
-	// TODO: the standard lib will check the validity
+	// TODO: the standard library will check the validity in future
 	s.RawString(str)
 }