Upgrade to Electron 34.0.1

Electron: 32.1.2 -> 34.0.1
Node: 20.17.0 -> 20.18.1

Author: tidy-dev

.github/workflows/ci.yml

@@ -38,7 +38,7 @@ on:
       APPLE_APPLICATION_CERT_PASSWORD:
 
 env:
-  NODE_VERSION: 20.17.0
+  NODE_VERSION: 20.18.1
 
 jobs:
   lint:

.node-version

@@ -1 +1 @@
-20.17.0
+20.18.1

.nvmrc

@@ -1 +1 @@
-v20.17.0
+20.18.1

.tool-versions

@@ -1,2 +1,2 @@
 python 3.9.5
-nodejs 20.17.0
+nodejs 20.18.1

app/src/main-process/app-window.ts

@@ -203,7 +203,7 @@ export class AppWindow {
     registerWindowStateChangedEvents(this.window)
     this.window.loadURL(encodePathAsUrl(__dirname, 'index.html'))
 
-    nativeTheme.addListener('updated', (event: string, userInfo: any) => {
+    nativeTheme.addListener('updated', () => {
       ipcWebContents.send(this.window.webContents, 'native-theme-updated')
     })
 

app/src/main-process/ipc-main.ts

@@ -56,7 +56,7 @@ function safeListener<E extends IpcMainEvent | IpcMainInvokeEvent, R>(
   return (event: E, ...args: any) => {
     if (!isTrustedIPCSender(event.sender)) {
       log.error(
-        `IPC message received from invalid sender: ${event.senderFrame.url}`
+        `IPC message received from invalid sender: ${event.senderFrame?.url}`
       )
       return
     }

package.json

@@ -152,7 +152,7 @@
     "@types/webpack": "^5.28.5",
     "@types/webpack-bundle-analyzer": "^4.7.0",
     "@types/webpack-hot-middleware": "^2.25.9",
-    "electron": "32.1.2",
+    "electron": "34.0.1",
     "electron-packager": "^17.1.1",
     "electron-winstaller": "^5.0.0",
     "eslint-plugin-github": "^5.1.5",

script/validate-electron-version.ts

@@ -19,7 +19,7 @@ type ChannelToValidate = 'production' | 'beta'
  */
 const ValidElectronVersions: Record<ChannelToValidate, string> = {
   production: '32.1.2',
-  beta: '32.1.2',
+  beta: '34.0.1',
 }
 
 // Only when we get a RELEASE_CHANNEL we know we're in the middle of a deployment.

yarn.lock

@@ -3295,10 +3295,10 @@ electron-winstaller@*, electron-winstaller@^5.0.0:
     lodash.template "^4.2.2"
     temp "^0.9.0"
 
-electron@32.1.2:
-  version "32.1.2"
-  resolved "https://registry.yarnpkg.com/electron/-/electron-32.1.2.tgz#84d1efd95d41224e58a6a9bbd1db4ba80154fc02"
-  integrity sha512-CXe6doFzhmh1U7daOvUzmF6Cj8hssdYWMeEPRnRO6rB9/bbwMlWctcQ7P8NJXhLQ88/vYUJQrJvlJPh8qM0BRQ==
+electron@34.0.1:
+  version "34.0.1"
+  resolved "https://registry.yarnpkg.com/electron/-/electron-34.0.1.tgz#bc2fdb8956831ba4c5c7d17bfa7b8780a7d635e7"
+  integrity sha512-aArw5tAM80i3CKwEREnyZSM1SkARf5Jd1yBMTIdOL4pB1M+p/oDeyWSFI9Dl+vujyfJKiK4SS5+j19wna1onMw==
   dependencies:
     "@electron/get" "^2.0.0"
     "@types/node" "^20.9.0"