## Critical Bugs Fixed ### Bug #7: WebSocket Callback Dangling Pointer (CRITICAL) - **File**: plugin/src/network/WebSocketClient.cpp - **Issue**: onError callback was captured by `this` in callAsync lambdas - **Risk**: Use-after-free if WebSocketClient destroyed before lambda executes - **Fix**: Capture callback by value instead of this pointer ### Bug #6 & #15: Static Variable Thread Safety (HIGH) - **File**: plugin/src/util/Result.h - **Issue**: getValue() returned reference to static local variable on error - **Risk**: Data corruption from concurrent access to mutable types - **Fix**: Throw exception instead, force use of getValueOr() or getValueOrElse() ### Bug #9: PluginEditor NetworkClient Callback (HIGH) - **File**: plugin/src/core/PluginEditor.cpp - **Issue**: Connection status callback accessed components without SafePointer - **Risk**: Dangling pointer after editor destruction - **Fix**: Use SafePointer to wrap callback and dispatch on message thread ### Bug #10: WebSocketClient Lambda Capture (HIGH) - **File**: plugin/src/network/WebSocketClient.cpp - **Issue**: dispatchMessage() captured this without protection - **Risk**: Use-after-free when WebSocket fires from ASIO thread - **Fix**: Capture message callback by value instead of this ### Bug #13: Async Timer Cleanup Race (MEDIUM) - **File**: plugin/src/util/Async.cpp - **Issue**: DelayTimer callback and cancelDelay() could race on map erase - **Risk**: Potential double-deletion or use-after-free - **Fix**: Check if timer still in map before executing callback ### Bug #14: BufferAudioPlayer Position TOCTOU (MEDIUM) - **File**: plugin/src/audio/BufferAudioPlayer.cpp - **Issue**: Position load and store had gap where seekToPosition() could interfere - **Risk**: Seek position overwritten by audio thread calculation - **Fix**: Use compare-and-swap to atomically update only if value unchanged ## Summary - 6 bugs fixed (2 CRITICAL, 4 HIGH/MEDIUM) - All fixes preserve backward compatibility - Enhanced thread safety on audio thread and message thread boundaries - Better memory safety with explicit error handling

a midi synthesizer in the plugin that plays music by default as an easter egg #6

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions