Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Loading of serizalized MixerType broken #47

Closed
2 tasks
GlaserN opened this issue Jul 26, 2023 · 2 comments
Closed
2 tasks

[BUG] - Loading of serizalized MixerType broken #47

GlaserN opened this issue Jul 26, 2023 · 2 comments
Labels
bug Something isn't working fix released fix to the issue / enhancement has been released jira Sync the issue to ZI LabOneQ internal issue tracker.

Comments

@GlaserN
Copy link

GlaserN commented Jul 26, 2023

Describe the bug
Loading a serialized experiment with a defined MixerType fails with:
ValueError: 'IQ' is not a valid MixerType

The serializer tries to instantiate the class with mapped_class(val), which is only valid for const arguments for the definition of the MixerType as introduced in 2.10, MixerType["IQ"] has to be called instead of MixerType("IQ").

To Reproduce
Try to load, for example, the following compiled experiment:
compiledexperiment.zip

Expected behavior
SerializedObject should still be able to load

Code & Screenshots
Versions used:

  • laboneq: 2.10
  • zhinst-core
  • others

Context

  • Do you know a workaround for the issue? If yes, please provide a short description.
  • Does the issue block your experiments?
@kshirer kshirer added bug Something isn't working jira Sync the issue to ZI LabOneQ internal issue tracker. labels Jul 28, 2023
@kshirer
Copy link
Collaborator

kshirer commented Jul 28, 2023

Hi @GlaserN, thanks for this. We're looking into it.

@kshirer
Copy link
Collaborator

kshirer commented Aug 10, 2023

Hi @GlaserN , this fix is included in the 2.12 release so I'm closing this issue.

@kshirer kshirer added the fix released fix to the issue / enhancement has been released label Aug 10, 2023
@kshirer kshirer closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix released fix to the issue / enhancement has been released jira Sync the issue to ZI LabOneQ internal issue tracker.
Projects
None yet
Development

No branches or pull requests

2 participants