Skip to content

Commit 5e21740

Browse files
authored
🌸 Components: Card does not need a gap-y (#2148)
- #2110 If we enforce a gap at the card level, it makes it hard to format things nicely in contexts where there should not be a gap between the header and footer. The `justify-between` is "enough" to ensure that the footer sticks to the bottom of the card, and the `header` and `footer` both provide padding. So no need to set that intention + enforce it multiple places; and this place seemed like the one that was least tailorable to the immediate usage context.
1 parent 91a1cf5 commit 5e21740

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎app/components/card_component.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div <%==attributes(classes: "shadow gap-y-3 rounded-lg bg-white group-hover:bg-slate-50 flex flex-col justify-between") %>>
1+
<div <%==attributes(classes: "shadow rounded-lg bg-white group-hover:bg-slate-50 flex flex-col justify-between") %>>
22
<% if header? %>
33
<%= header%>
44
<%- end %>

0 commit comments

Comments
 (0)