Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔖🐞 Journal:Keyword does not handle diacritics correctly #15

Open
anaulin opened this issue Dec 21, 2023 · 2 comments
Open

🔖🐞 Journal:Keyword does not handle diacritics correctly #15

anaulin opened this issue Dec 21, 2023 · 2 comments
Labels
🐞 bug 🥇 good first issue

Comments

@anaulin
Copy link
Member

anaulin commented Dec 21, 2023 •
edited
Loading

Screenshot 2023-12-21 at 1 48 56 PM

Test case examples: Lórien, Rûnaer, mañana, coöp
@anaulin anaulin changed the title 🐞 🐞 Journal:Keyword does not handle diacritics correctly Dec 21, 2023
@zspencer zspencer mentioned this issue Jan 29, 2024
Open
5 tasks
@zspencer
Copy link
Member

zspencer commented Dec 21, 2023 •
edited
Loading

For anyone who wants to try and fix this...

The bug is likely in Journal::Keyword.extract_and_create_from!, which has a test!

@anaulin
Copy link
Member Author

anaulin commented Dec 21, 2023 •
edited
Loading

More specifically, the bug is likely in the regex in scan(/#(\w+)/), which is using \w to select for "word", which matches [a-z, A-Z, 0-9], but does not seem to match e.g. á.

@zspencer zspencer transferred this issue from zinc-collective/convene Jan 30, 2024
@zspencer zspencer changed the title 🐞 Journal:Keyword does not handle diacritics correctly 🐞🔖 Journal:Keyword does not handle diacritics correctly Jan 30, 2024
@zspencer zspencer changed the title 🐞🔖 Journal:Keyword does not handle diacritics correctly 🔖🐞 Journal:Keyword does not handle diacritics correctly Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug 🥇 good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zspencer @anaulin