Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humanize panic handling? #22

Closed
Tracked by #45
zkat opened this issue Aug 18, 2021 · 1 comment
Closed
Tracked by #45

Humanize panic handling? #22

zkat opened this issue Aug 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@zkat
Copy link
Owner

zkat commented Aug 18, 2021

https://github.com/rust-cli/human-panic seems neat. Is this something miette should do? I'm not sure

@drmason13
Copy link

If it helps, I think this is safe to consider out of scope for Miette.

Having said that, it would be nice to add a mention to the README. Something like:

While you're considering beautiful error outputs for human users of you application...
Have you considered what panic messages look like?
Miette doesn't alter Rust's default panic messages.
You could use a crate like human-panic which does, or even write your own std::panic::set_hook to gain the most flexibility.

I was a bit surprised that the message in human-panic is hardcoded, see: rust-cli/human-panic#54. I wouldn't want to force the exact text they use on users of Miette. Could be a good contribution to human-panic to add a custom message feature (for 2.0.0).

@zkat zkat added the enhancement New feature or request label Sep 10, 2021
@zkat zkat mentioned this issue Sep 10, 2021
14 tasks
@zkat zkat closed this as completed in c6daee7 Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants