Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zonemaster CLI aborts testing immediately on CRITICAL messages. #394

Open
mattias-p opened this issue Nov 13, 2024 · 0 comments
Open

Zonemaster CLI aborts testing immediately on CRITICAL messages. #394

mattias-p opened this issue Nov 13, 2024 · 0 comments
Labels
T-Bug Type: Bug in software or error in test case description
Milestone

Comments

@mattias-p
Copy link
Member

When Engine emits a CRITICAL message, CLI used to continue testing unless --stop-level has been explicitly set, resulting in output like this:

$ zonemaster-cli --no-ipv6 --no-time --raw mail.protection.outlook.com
CRITICAL B02_NO_WORKING_NS  domain="mail.protection.outlook.com"
ERROR    B02_UNEXPECTED_RCODE  ns=ns2-proddns.glbdns.protection.outlook.com/104.47.72.81; rcode=FORMERR
ERROR    B02_UNEXPECTED_RCODE  ns=ns1-proddns.glbdns.protection.outlook.com/104.47.34.49; rcode=FORMERR
CRITICAL CANNOT_CONTINUE  domain=mail.protection.outlook.com

However #371 inadvertently changed this behavior so that test case execution terminates immediately if a CRITICAL message is emitted.

CRITICAL B02_NO_WORKING_NS  domain="mail.protection.outlook.com"
Exited early: Saw message at level CRITICAL

The new behavior makes it harder to develop test cases that emit CRITICAL messages.

This was first reported in the PR thread of #389.

@mattias-p mattias-p added the T-Bug Type: Bug in software or error in test case description label Nov 13, 2024
@mattias-p mattias-p added this to the v2024.2 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Development

No branches or pull requests

1 participant