Reword does not respond messages

[jsoref]

https://github.com/search?q=repo%3Azonemaster%2Fzonemaster-engine+%2Fname+%3Fserver.*+does+not+respond%2F+NOT+language%3A%22Gettext+Catalog%22+language%3APerl++NOT+path%3A%2F%5Et%5C%2F%2F&type=code

zonemaster-engine/lib/Zonemaster/Engine/Test/Basic.pm

Line 252 in 17688f7

'Name server "{ns}" does not respond to an SOA query.', @_;

see #1353 for name server vs nameserver

zonemaster-engine/lib/Zonemaster/Engine/Test/Connectivity.pm

Line 193 in 17688f7

'Nameserver {ns} does not respond to NS queries over UDP.', @_;

zonemaster-engine/lib/Zonemaster/Engine/Test/Connectivity.pm

Line 197 in 17688f7

'Nameserver {ns} does not respond to SOA queries over UDP.', @_;

zonemaster-engine/lib/Zonemaster/Engine/Test/Connectivity.pm

Line 201 in 17688f7

'Nameserver {ns} does not respond to any queries over UDP.', @_;

zonemaster-engine/lib/Zonemaster/Engine/Test/Connectivity.pm

Line 237 in 17688f7

'Nameserver {ns} does not respond to NS queries over TCP.', @_;

zonemaster-engine/lib/Zonemaster/Engine/Test/Connectivity.pm

Line 241 in 17688f7

'Nameserver {ns} does not respond to SOA queries over TCP.', @_;

zonemaster-engine/lib/Zonemaster/Engine/Test/Connectivity.pm

Line 245 in 17688f7

'Nameserver {ns} does not respond to any queries over TCP.', @_;

zonemaster-engine/lib/Zonemaster/Engine/Test/Zone.pm

Line 405 in 17688f7

'SOA MNAME name server "{ns}" does not respond to an SOA query.', @_;

Unlike most messages where zonemaster-engine has received a response and is able to critique what it receives, and can thus reasonable assert that what it got was what the server sent, when zonemaster-engine doesn't receive a response, it doesn't actually know if the server didn't receive the request, didn't send a response, or if the response was lost somewhere along the way.

It would be better to say:

Did not receive response to query for X via Y from name server {ns}

query for X via Y could be:

• NS queries over UDP
• NS queries over TCP
• SOA queries over UDP
• any queries over UDP
• NS queries over TCP
• any queries over TCP
• an SOA query

name server could be:

• name server
• SOA MNAME name server

[matsduf]

@jsoref, thank you for your comments. See #1353.

[tgreenx]

Unlike most messages where zonemaster-engine has received a response and is able to critique what it receives, and can thus reasonable assert that what it got was what the server sent, when zonemaster-engine doesn't receive a response, it doesn't actually know if the server didn't receive the request, didn't send a response, or if the response was lost somewhere along the way.

Right, I agree.

It would be better to say:

Did not receive response to query for X via Y from name server {ns}

Perhaps we could simply reword it as such instead:

No response received from name server {ns} to {query_type} query (or queries, if applicable)

[matsduf]

Perhaps we could simply reword it as such instead:

No response received from nameserver {ns} to {query_type} query (or queries, if applicable)

Technically it is always queries, but I think query is simpler. I think that "name server" is the preferred alternative instead of "nameserver". For some test cases there should be room for "over TCP" or "over UDP".

[tgreenx]

Perhaps we could simply reword it as such instead:
No response received from nameserver {ns} to {query_type} query (or queries, if applicable)

I think that "name server" is the preferred alternative instead of "nameserver".

Indeed, I unintentionally misspelled. Edited.

For some test cases there should be room for "over TCP" or "over UDP".

Sure, that's fine.

[jsoref]

I think I agree w/ the idea of simplifying queries to query (from an end user's perspective, and even conceptually, the client here is performing a query to the remote Domain Name System server -- it just happens to be sending a number of individual queries in order to perform that greater query action), but trying to do too many things at once seems like it's going to trip me up badly. (I've already managed to create a PR to my fork instead of to this repo for the other issue.)

In an effort to avoid creating too many merge conflicts for myself, I'm inclined to only try to change does not respond to No response received... as part of this issue, and once this (and maybe the other open ticket) are resolved, I can make a third ticket (or just a PR if people are ok w/ that) to shift queries to query in certain limited instances.

Anyway, I'm going to start by seeing if I can get this to work in a private fork today, and if I can, I'll submit a PR.

[matsduf]

Please note that if the message is specified in the test case specification (e.g. specification for Basic02) then it should be updated there too, or more correctly, there first.