Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DNSSEC15, DNSSEC16 and DNSSEC17 with proper code #908

Open
matsduf opened this issue May 20, 2021 · 1 comment · Fixed by zonemaster/zonemaster-ldns#199
Open

Update DNSSEC15, DNSSEC16 and DNSSEC17 with proper code #908

matsduf opened this issue May 20, 2021 · 1 comment · Fixed by zonemaster/zonemaster-ldns#199
Assignees
Labels
A-TestCase Area: Test case specification or implementation of test case
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented May 20, 2021

The implementations of DNSSEC15, DNSSEC16 and DNSSEC17 have a work-around on the handling of CDS and CDNSKEY records due to missing Zonemaster-LDNS code (see zonemaster/zonemaster-ldns/issues/114):

See "s/\s+CDS\s+/ DS /" and "s/\s+CDNSKEY\s+/ DNSKEY /" in DNSSEC15 code:

foreach my $cds ( @{ $cds_rrsets{ $ns_ip } } ) {
  my $rr_string = $cds->string;
  $rr_string =~ s/\s+CDS\s+/ DS /;
  push @ds, Zonemaster::LDNS::RR->new( $rr_string );
}
foreach my $cdnskey ( @{ $cdnskey_rrsets{ $ns_ip } } ) {
  my $rr_string = $cdnskey->string;
  $rr_string =~ s/\s+CDNSKEY\s+/ DNSKEY /;
  push @dnskey, Zonemaster::LDNS::RR->new( $rr_string );
}

And similar in DNSSEC16 and DNSSEC17.

@matsduf matsduf added this to the v2021.2 milestone May 20, 2021
@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Jun 17, 2021
@matsduf matsduf modified the milestones: v2021.2, v2022.1 Dec 8, 2021
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@tgreenx
Copy link
Contributor

tgreenx commented Sep 17, 2024

Zonemaster-LDNS now have proper CDS/CDNSKEY RRs support, see zonemaster/zonemaster-ldns#199.

However the issue raised here isn't actually solved by this added support. The responsibility lies in LDNS itself. It should be fixed in their next release, see zonemaster/zonemaster-ldns#114 (comment).

@tgreenx tgreenx self-assigned this Sep 17, 2024
@tgreenx tgreenx linked a pull request Sep 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants