Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check MANIFEST when PR is created (zonemaster-ldns) #119

Open
matsduf opened this issue May 20, 2021 · 0 comments · Fixed by #195
Open

Check MANIFEST when PR is created (zonemaster-ldns) #119

matsduf opened this issue May 20, 2021 · 0 comments · Fixed by #195
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue
Milestone
v2024.2

Comments

@matsduf
Copy link
Contributor

matsduf commented May 20, 2021

Whenever a file is added or removed MANIFEST or MANIFEST.SKIP must be updated. This is something that is often missed by all developers.

Add a test so that Travis/Github action complains if MANIFEST* is not correct, comparable to make distcheck.

Also see zonemaster/zonemaster-engine/issues/902 and zonemaster/zonemaster-engine/issues/903.
@matsduf matsduf added this to the v2021.2 milestone May 20, 2021
@matsduf matsduf modified the milestones: v2021.2, v2022.1 Dec 8, 2021
@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@MichaelTimbert MichaelTimbert mentioned this issue Aug 19, 2024
Merged
@tgreenx tgreenx added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Aug 20, 2024
@MichaelTimbert MichaelTimbert mentioned this issue Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue
Projects
None yet
Milestone
v2024.2
Development

Successfully merging a pull request may close this issue.

Check MANIFEST when PR is created MichaelTimbert/zonemaster-ldns
2 participants
@matsduf @tgreenx