Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change commit user name #863

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Change commit user name #863

merged 1 commit into from
Nov 18, 2024

Conversation

v1gnesh
Copy link
Collaborator

@v1gnesh v1gnesh commented Sep 21, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Content Update

Category

  • zopen framework
  • Documentation
  • CI/CD
  • Tools

Description

Related Issues

  • Related Issue #
  • Closes #

[optional] Are there any post-deployment tasks or follow-up actions required?

Copy link
Collaborator

@IgorTodorovskiIBM IgorTodorovskiIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I believe this correspondings to the github id: https://github.com/zosopentoolsmain . @MikeFultonDev we may need to change this id name as well

@v1gnesh
Copy link
Collaborator Author

v1gnesh commented Nov 12, 2024

@IgorTodorovskiIBM when you can spare a few mins, please review.

@IgorTodorovskiIBM
Copy link
Collaborator

@IgorTodorovskiIBM when you can spare a few mins, please review.

Do you know if the commit user name needs to match a github id? We still use https://github.com/zosopentoolsmain. We could probably rename it to zopenmain or zopencommunitymain

@v1gnesh
Copy link
Collaborator Author

v1gnesh commented Nov 16, 2024

It used to work with the non-existent bump. Raising this as just a chore; doesn't really need fixing.
#437

Copy link
Collaborator

@IgorTodorovskiIBM IgorTodorovskiIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit bb2835f into main Nov 18, 2024
1 check failed
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the v1gnesh-patch-1 branch November 18, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants