Skip to content

Commit f17c6e8

Browse files
committed
Remove loading ui state
1 parent 07e2de7 commit f17c6e8

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

features/users/src/main/kotlin/com/sample/architecturecomponents/feature/users/UsersViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class UsersViewModel @Inject constructor(
4747
private fun Flow<Result<List<User>>>.getUsers(): Job =
4848
mapNotNull { item ->
4949
when(item) {
50-
Result.Loading -> if (_state.value is UsersUiState.Loading) UsersUiState.Loading else null
50+
Result.Loading -> null
5151
is Result.Error -> throw item.exception
5252
is Result.Success -> UsersUiState.Success(users = item.data, isBottomProgress = false)
5353
}

features/users/src/test/kotlin/com/sample/architecturecomponents/feature/users/UsersViewModelTest.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import kotlinx.coroutines.test.runTest
88
import org.junit.Before
99
import org.junit.Rule
1010
import org.junit.Test
11-
import kotlin.test.assertEquals
1211

1312
class UsersViewModelTest {
1413

@@ -35,7 +34,7 @@ class UsersViewModelTest {
3534
@Test
3635
fun loadingUsersViewModelTest() = runTest {
3736
val items = viewModel.state.first()
38-
assertEquals(UsersUiState.Loading, items)
37+
assert(items is UsersUiState.Success)
3938
}
4039

4140
}

0 commit comments

Comments
 (0)