NoMethodError: undefined method `formatter='

[mhenrixon]

TwP/logging#245

Crossposting in case you depend on twp/logging and need a version bump or something.

[zormandi]

Thanks, I'll look into it. 👍

[brandondrew]

I'm getting the error with Rails 7.0.7.2:

 undefined method `formatter=' for #<Logging::Logger:0x0000000123555d38 @name="Application", @parent=#<Logging::RootLogger:0x0000000117f18c50 @name="root", @appenders=[#<Logging::Appenders::Stdout:0x00000001229fed90 @io=#<IO:<STDOUT>>, @close_method=:close, @buffer=[], @immediate=[], @auto_flushing=1, @async=false, @async_flusher=nil, @flush_period=nil, @name="stdout", @closed=false, @filters=[], @mutex=#<ReentrantMutex:0x00000001229da878 @locker=nil>, @layout=#<Logcraft::LogLayout:0x00000001229bb8b0 @global_context={}, @formatter=#<Proc:0x0000000121a33e60 /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/logcraft-2.1/lib/logcraft/log_layout.rb:7 (lambda)>, @level_formatter=#<Proc:0x0000000121a33de8 /Users/brandon/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/logcraft-2.1/lib/logcraft/log_layout.rb:8 (lambda)>>, @level=0, @encoding=#<Encoding:UTF-8>, @write_size=500>], @additive=false, @caller_tracing=false, @level=1>, @appenders=[], @additive=true, @level=1, @caller_tracing=false> (NoMethodError)

        logger.formatter = ActiveSupport::Logger::SimpleFormatter.new
              ^^^^^^^^^^^^

[zormandi]

@brandondrew I couldn't reproduce the issue with Rails 7.0.7.2. All tests run fine. Unless, of course, you're calling logger.formatter = ... explicitly, which you shouldn't do. If this is in a newly generated Rails configuration then you should remove those lines.

[zormandi]

New version is released which fixes compatibility issues with Rails 7.1.

[mhenrixon]

Thank you! I'll give it a spin later today.

[mhenrixon]

Seems to work like a charm so closing!

[lauer]

UPDATE: Sorry, it seems to be a problem with dotenv-rails after upgrading from 2.8.1 to 3.0.0 of that gem.
and maybe its connected to use of GoodJob - bensheldon/good_job#1247

--
It seems like I have the same bug in Rails 7.1.3, after I start to use broadcast/hotwire, or maybe I have misconfigured something?

16:05:23 web.1 | /Users/jesper.laursen/.dotfiles/link/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/activesupport-7.1.3/lib/active_support/broadcast_logger.rb:146:in block in formatter=': undefined method formatter=' for #<Logging::Logger:0x0000000114892be0 @name="Application", @parent=#<Logging::RootLogger:0x0000000114817620 @name="root", @appenders=[#<Logging::Appenders::Stdout:0x0000000113698840 @io=#<IO:<STDOUT>>, @close_method=:close, @buffer=[], @immediate=[], @auto_flushing=1, @async=false, @async_flusher=nil, @flush_period=nil, @name="stdout", @closed=false, @filters=[], @mutex=#<ReentrantMutex:0x0000000113698340 @locker=nil>, @layout=#<Logcraft::LogLayout:0x000000011489a570 @global_context={}, @formatter=#<Proc:0x0000000113698cf0 /Users/jesper.laursen/.dotfiles/link/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/logcraft-2.2.1/lib/logcraft/log_layout.rb:7 (lambda)>, @level_formatter=#<Proc:0x0000000113698c78 /Users/jesper.laursen/.dotfiles/link/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/logcraft-2.2.1/lib/logcraft/log_layout.rb:8 (lambda)>>, @level=0, @encoding=#<Encoding:UTF-8>, @write_size=500>], @additive=false, @caller_tracing=false, @level=1>, @appenders=[], @additive=true, @level=1, @caller_tracing=false, @logdev=#<OpenStruct dev=#<IO:<STDOUT>>>> (NoMethodError)

[juna-nb]

@lauer this change (yet un-merged) fixed the issue for me. Thanks for corroborating that it might be a dotenv issue.
bkeepers/dotenv#489

[mhenrixon]

This has now been fixed in logging.

[zormandi-byborg]

Thanks for the update. 👍