From 0ea653eec6b01116e302f8b3b800fc1ddcad0dc4 Mon Sep 17 00:00:00 2001
From: Miltiadis Vasilakis <mvasilak@gmail.com>
Date: Thu, 25 Apr 2024 09:27:41 +0300
Subject: [PATCH] Improve open items bar button image creation

---
 Zotero/Controllers/OpenItemsController.swift               | 7 +++++++
 Zotero/Scenes/Detail/Items/Views/ItemsViewController.swift | 6 +++---
 .../Scenes/Detail/PDF/Views/PDFReaderViewController.swift  | 4 ++--
 Zotero/Scenes/General/Views/NoteEditorViewController.swift | 4 ++--
 4 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/Zotero/Controllers/OpenItemsController.swift b/Zotero/Controllers/OpenItemsController.swift
index 7de763522..2a7ce792a 100644
--- a/Zotero/Controllers/OpenItemsController.swift
+++ b/Zotero/Controllers/OpenItemsController.swift
@@ -479,3 +479,10 @@ extension OpenItemsController {
         viewController.set(userActivity: activity)
     }
 }
+
+extension UIImage {
+    static func openItemsImage(count: Int) -> UIImage? {
+        let count = max(0, count)
+        return count <= 50 ? UIImage(systemName: "\(count).square") : UIImage(systemName: "square.grid.3x3.square")
+    }
+}
diff --git a/Zotero/Scenes/Detail/Items/Views/ItemsViewController.swift b/Zotero/Scenes/Detail/Items/Views/ItemsViewController.swift
index fbe103e07..c6e56666c 100644
--- a/Zotero/Scenes/Detail/Items/Views/ItemsViewController.swift
+++ b/Zotero/Scenes/Detail/Items/Views/ItemsViewController.swift
@@ -487,8 +487,8 @@ final class ItemsViewController: UIViewController {
     }
 
     private func updateRestoreOpenItemsButton(withCount count: Int) {
-        guard let item = self.navigationItem.rightBarButtonItems?.first(where: { button in RightBarButtonItem(rawValue: button.tag) == .restoreOpenItems }) else { return }
-        item.image = UIImage(systemName: "\(count).square")
+        guard let item = navigationItem.rightBarButtonItems?.first(where: { button in RightBarButtonItem(rawValue: button.tag) == .restoreOpenItems }) else { return }
+        item.image = .openItemsImage(count: count)
     }
     
     private func setupRightBarButtonItems(for state: ItemsState) {
@@ -583,7 +583,7 @@ final class ItemsViewController: UIViewController {
                 }
 
             case .restoreOpenItems:
-                image = UIImage(systemName: "0.square")
+                image = .openItemsImage(count: 0)
                 accessibilityLabel = L10n.Items.restoreOpen
                 primaryAction = UIAction { [weak self] _ in
                     guard let self, let presenter, let controller = controllers.userControllers?.openItemsController, let sessionIdentifier = getSessionIdentifier() else { return }
diff --git a/Zotero/Scenes/Detail/PDF/Views/PDFReaderViewController.swift b/Zotero/Scenes/Detail/PDF/Views/PDFReaderViewController.swift
index 9797f05f0..f8cb47acb 100644
--- a/Zotero/Scenes/Detail/PDF/Views/PDFReaderViewController.swift
+++ b/Zotero/Scenes/Detail/PDF/Views/PDFReaderViewController.swift
@@ -107,7 +107,7 @@ class PDFReaderViewController: UIViewController {
         return share
     }()
     private lazy var openItemsButton: UIBarButtonItem = {
-        let openItems = UIBarButtonItem(image: UIImage(systemName: "0.square"), style: .plain, target: nil, action: nil)
+        let openItems = UIBarButtonItem(image: .openItemsImage(count: 0), style: .plain, target: nil, action: nil)
         openItems.isEnabled = true
         openItems.accessibilityLabel = L10n.Accessibility.Pdf.openItems
         openItems.title = L10n.Accessibility.Pdf.openItems
@@ -685,7 +685,7 @@ class PDFReaderViewController: UIViewController {
     private func createRightBarButtonItems(for state: PDFReaderState) -> [UIBarButtonItem] {
         var buttons = [settingsButton, shareButton, searchButton]
         buttons.insert(openItemsButton, at: 1)
-        openItemsButton.image = .init(systemName: "\(state.openItemsCount).square")
+        openItemsButton.image = .openItemsImage(count: state.openItemsCount)
 
         if state.library.metadataEditable {
             buttons.append(toolbarButton)
diff --git a/Zotero/Scenes/General/Views/NoteEditorViewController.swift b/Zotero/Scenes/General/Views/NoteEditorViewController.swift
index c520777ca..340a499d4 100644
--- a/Zotero/Scenes/General/Views/NoteEditorViewController.swift
+++ b/Zotero/Scenes/General/Views/NoteEditorViewController.swift
@@ -101,7 +101,7 @@ final class NoteEditorViewController: UIViewController {
                     item = done
 
                 case .restoreOpenItems:
-                    let openItems = UIBarButtonItem(image: UIImage(systemName: "0.square"), style: .plain, target: nil, action: nil)
+                    let openItems = UIBarButtonItem(image: .openItemsImage(count: 0), style: .plain, target: nil, action: nil)
                     openItems.isEnabled = true
                     openItems.accessibilityLabel = L10n.Accessibility.Pdf.openItems
                     openItems.title = L10n.Accessibility.Pdf.openItems
@@ -129,7 +129,7 @@ final class NoteEditorViewController: UIViewController {
 
             func updateRestoreOpenItemsButton(withCount count: Int) {
                 guard let item = navigationItem.rightBarButtonItems?.first(where: { button in RightBarButtonItem(rawValue: button.tag) == .restoreOpenItems }) else { return }
-                item.image = UIImage(systemName: "\(count).square")
+                item.image = .openItemsImage(count: count)
             }
 
             func forceSaveIfNeeded() {