Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light flares (r_flares 2) fade state is not consistent across frames #314

Open
zturtleman opened this issue Jun 14, 2020 · 0 comments
Open

Comments

@zturtleman
Copy link
Owner

Light flares (added by r_flares 2 or 3) connect fade state from the previous frame based on the light number added to the scene (see this line of tr_flares.c). This is not consistent as light are added or removed from the view. It can result in light flares being temporarily visible through walls.

This can probably be fixed using RTCW corona method of include an id (usually the entity number) to properly connect fade state across frames. Adding "visible" boolean to lights with result from collision trace like corona would help improve light flare performance by reducing framebuffer reads.

Issue found by Tobias Kuehnhammer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant