Skip to content

Commit 55b7ac6

Browse files
committed
fix(users): added email field in controller that was unused
1 parent 7d0a040 commit 55b7ac6

File tree

3 files changed

+21
-9
lines changed

3 files changed

+21
-9
lines changed

users-service/src/main/kotlin/piperkt/services/users/infrastructure/persistence/model/UserEntityMapper.kt

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,24 @@ import piperkt.services.users.domain.user.Username
77
object UserEntityMapper {
88
/** Convert a user entity to a user. */
99
fun UserEntity.toDomain() =
10-
User(Username(username), password, email, description, profilePicture, refreshToken)
10+
User(
11+
username = Username(username),
12+
password = password,
13+
email = email,
14+
description = description,
15+
profilePicture = profilePicture,
16+
refreshToken = refreshToken
17+
)
1118

1219
/** Convert a user to a user entity. */
1320
fun User.toEntity() =
1421
UserEntity(
1522
id = null,
16-
username.value,
17-
password,
18-
email,
19-
description,
20-
profilePicture,
21-
refreshToken
23+
username = username.value,
24+
password = password,
25+
email = email,
26+
description = description,
27+
profilePicture = profilePicture,
28+
refreshToken = refreshToken
2229
)
2330
}

users-service/src/main/kotlin/piperkt/services/users/interfaces/web/controllers/RegisterController.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ class RegisterController(private val authService: AuthService) : RegisterApi {
1919
.register(
2020
request.username,
2121
request.password,
22+
request.email,
2223
request.description,
2324
request.profilePicture
2425
)

users-service/src/test/kotlin/piperkt/services/users/interfaces/web/auth/RegisterControllerTest.kt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,13 @@ class RegisterControllerTest(
4444
afterEach { authService.delete(user.username.value) }
4545

4646
test("register") {
47-
val response = authClient.register(RegisterApi.RegisterRequest("newuser", "password"))
47+
val response =
48+
authClient.register(
49+
RegisterApi.RegisterRequest("newuser", "password", "email", "description")
50+
)
4851
response.username shouldBe "newuser"
49-
response.description shouldBe null
52+
response.description shouldBe "description"
53+
response.email shouldBe "email"
5054
response.profilePicture shouldBe null
5155
authService.delete("newuser")
5256
}

0 commit comments

Comments
 (0)