Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support starting a new DM conversation #127

Open
chrisbobbe opened this issue May 26, 2023 · 8 comments · May be fixed by #1322
Open

Support starting a new DM conversation #127

chrisbobbe opened this issue May 26, 2023 · 8 comments · May be fixed by #1322
Labels
a-home The home screens of the app; finding and starting conversations
Milestone

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented May 26, 2023

This corresponds to the "New DM" and "New group DM" buttons which zulip-mobile has at the top of the DM-conversations screen.

Design

The design for this UI is in Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4923-3308&t=dosxggnU7UlsrbfI-0

Here's one screenshot:
image

For details, see the Figma doc.

Related issues

@gnprice gnprice added this to the Beta milestone May 27, 2023
@gnprice gnprice removed the m-beta label May 27, 2023
@gnprice gnprice added the a-home The home screens of the app; finding and starting conversations label Jun 14, 2023
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@Khader-1
Copy link
Collaborator

Do we have any design expectations here?

@chrisbobbe
Copy link
Collaborator Author

I expect we'll want to wait for our designer to propose a design for this feature, yes.

@gnprice
Copy link
Member

gnprice commented Dec 28, 2024

We have a design for this feature now; I've updated the description.

@Dhanesh-Sawant
Copy link

Dhanesh-Sawant commented Jan 2, 2025

I would like to work on this issue

I have started it with adding the design when there are no dm's yet as required in #F385

WhatsApp Image 2025-01-02 at 08 39 48

@Dhanesh-Sawant
Copy link

this is just the test for search functionality in direct messages, the search box design is just for testing now & will finalize it once I finish doing for groups also

dm.mp4

@Dhanesh-Sawant
Copy link

Here I have implemented the functionality of starting a conversation with a person or in a group after clicking new dm button.

  • be able to search for members
  • add members to the selected users required for forming a group almost same as the required design(some changes are needed to be done further as this was just for testing).
new.dm.mp4

Dhanesh-Sawant added a commit to Dhanesh-Sawant/zulip-flutter that referenced this issue Jan 3, 2025
Implemented the UI for the "No DMs yet" state on the RecentDmConversationsPage according to the design provided.

Fixes part of zulip#127
@chimnayajith
Copy link

The PR for this seems to be abandoned. I'd like to work on this issue.

@Dhanesh-Sawant
Copy link

hey @chimnayajith, I was caught up by something else, but I've started working on it again..

chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 4, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message lsit after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 4, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message lsit after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
@chimnayajith chimnayajith linked a pull request Feb 4, 2025 that will close this issue
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 5, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message lsit after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 5, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message list after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 5, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message list after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 6, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message list after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 15, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message list after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 15, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message list after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
chimnayajith pushed a commit to chimnayajith/zulip-flutter that referenced this issue Feb 16, 2025
Add a modal bottom sheet UI for starting direct messages:
- Search and select users from global list
- Support single and group DMs
- Navigate to message list after selection

Design reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4903-31879&p=f&t=pQP4QcxpccllCF7g-0
Fixes: zulip#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-home The home screens of the app; finding and starting conversations
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants