Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon for "switch account" in main menu #1178

Open
gnprice opened this issue Dec 19, 2024 · 6 comments · May be fixed by #1180 or #1338
Open

Icon for "switch account" in main menu #1178

gnprice opened this issue Dec 19, 2024 · 6 comments · May be fixed by #1180 or #1338
Labels
a-design Visual and UX design a-home The home screens of the app; finding and starting conversations help wanted
Milestone
M5-a: Server 10

Comments

@gnprice
Copy link
Member

gnprice commented Dec 19, 2024

The "switch account" item in the main menu currently lacks an icon, unlike all the other items in the menu.

This looks kind of odd. We should put some kind of icon there.

In the future this item will be replaced:

but that may be post-launch, and this odd icon-less gap should be fixed before launch. Adding an icon here is trivial, once we pick an icon for it.
@gnprice gnprice added a-home The home screens of the app; finding and starting conversations a-design Visual and UX design labels Dec 19, 2024
@gnprice gnprice added this to the M5: Launch milestone Dec 19, 2024
@Pudv95

This comment has been minimized.

Sign in to view
@Pudv95

This comment has been minimized.

Sign in to view
@Pudv95 Pudv95 linked a pull request Dec 20, 2024 that will close this issue
Open
This was referenced Dec 21, 2024
Closed
Open
@AshutoshKhadse23

This comment has been minimized.

Sign in to view
@AshutoshKhadse23 AshutoshKhadse23 mentioned this issue Dec 22, 2024
Closed
@gnprice
Copy link
Member Author

gnprice commented Dec 23, 2024

We have an icon chosen now by @terpimost:
https://lucide.dev/icons/arrow-left-right

@lakshya1goel
Copy link
Contributor

Hello, Can I take up this issue?

@rishichirchi rishichirchi mentioned this issue Jan 3, 2025
Closed
@terpimost
Copy link

terpimost commented Jan 3, 2025 •
edited
Loading

I suggest to take icons from https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6141-40422&t=GgVgL6jkG9g2dI0G-1

They are optimized there to be ok converted to a font.

arrow-left-right

@gnprice gnprice modified the milestones: M5: Launch, M5-a: Server 10 Jan 14, 2025
@rishichirchi rishichirchi mentioned this issue Jan 19, 2025
Closed
@rishichirchi rishichirchi linked a pull request Feb 7, 2025 that will close this issue
Open
@chimnayajith chimnayajith mentioned this issue Feb 7, 2025
Open
rishichirchi added a commit to rishichirchi/zulip-flutter that referenced this issue Feb 12, 2025
@rishichirchi
fixes_icon: Add icon for switch account, from Figma
0dcab2c 
Taken from Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6141-40422&t

Fixes Icon for "switch account" in main menu zulip#1178
rishichirchi added a commit to rishichirchi/zulip-flutter that referenced this issue Feb 15, 2025
@rishichirchi
icons: Add icon for switch account in main menu
17347f1 
Fixes: Icon for "switch account" in main menu zulip#1178
rishichirchi added a commit to rishichirchi/zulip-flutter that referenced this issue Feb 20, 2025
@rishichirchi
icons: Add switch account icon in main menu
afcfbfd 
Fixes zulip#1178.
rishichirchi added a commit to rishichirchi/zulip-flutter that referenced this issue Feb 21, 2025
@rishichirchi
home: Add switch account icon in main menu
4e92be1 
Fixes zulip#1178.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-design Visual and UX design a-home The home screens of the app; finding and starting conversations help wanted
Projects
Flutter app
Status: No status
Milestone
M5-a: Server 10
5 participants
@gnprice @terpimost @Pudv95 @lakshya1goel @AshutoshKhadse23