Skip to content

fix(config): correct Fibaro FGMS001 association groups #7463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

xyanide
Copy link
Contributor

@xyanide xyanide commented Dec 7, 2024

I had a lot of trouble with setting up associations with my FGMS001 motion sensor from Fibaro.
Turns out the configuration in the documentation was incorrect. After reviewing the documentation at https://manuals.fibaro.com/motion-sensor/ I came to the conclusion ZwaveJS was reporting the associations groups incorrectly.

ZwaveJS documentation link: https://devices.zwave-js.io/?jumpTo=0x010f:0x0800:0x1001:0.0#

This PR corrects the association group names and limits.

Group information:

1st Association Group – “Lifeline” reports the device status and allows for assigning single device only (main controller by default).
2nd Association Group – “Motion” is assigned to the motion sensor – sends motion detection and alarm cancellation frames to the associated devices.
3rd Association Group – “Tamper” is assigned to the tamper – sends tamper alarm and alarm cancellation frames to the associated devices.
4th Association Group – “Motion BC” is assigned to the motion sensor – sends motion detection and alarm cancellation frames to the associated devices. Provides backward compatibility with controllers not supporting Z-Wave+ protocol.
5th Association Group – “Tamper BC” is assigned to the tamper – sends tamper alarm and alarm cancellation frames to the associated devices. Provides backward compatibility with controllers not supporting Z-Wave+ protocol.

https://manuals.fibaro.com/motion-sensor/

Group information:

1st Association Group – “Lifeline” reports the device status and allows for assigning single device only (main controller by default).
2nd Association Group – “Motion” is assigned to the motion sensor – sends motion detection and alarm cancellation frames to the associated devices.
3rd Association Group – “Tamper” is assigned to the tamper – sends tamper alarm and alarm cancellation frames to the associated devices.
4th Association Group – “Motion BC” is assigned to the motion sensor – sends motion detection and alarm cancellation frames to the associated devices. Provides backward compatibility with controllers not supporting Z-Wave+ protocol.
5th Association Group – “Tamper BC” is assigned to the tamper – sends tamper alarm and alarm cancellation frames to the associated devices. Provides backward compatibility with controllers not supporting Z-Wave+ protocol.
@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Dec 7, 2024
@xyanide xyanide changed the title Update fgms001.json to conform to Fibaro official documentation feat(config): Update fgms001.json to conform to Fibaro official documentation Dec 7, 2024
@xyanide xyanide changed the title feat(config): Update fgms001.json to conform to Fibaro official documentation fix(config): Update fgms001.json to conform to Fibaro official documentation Dec 7, 2024
@xyanide xyanide changed the title fix(config): Update fgms001.json to conform to Fibaro official documentation fix(config): Update fgms001 doc to conform to Fibaro official Dec 7, 2024
@xyanide xyanide changed the title fix(config): Update fgms001 doc to conform to Fibaro official fix(config): Update Fibaro fgms001 doc to conform to Fibaro official Dec 7, 2024
@xyanide xyanide changed the title fix(config): Update Fibaro fgms001 doc to conform to Fibaro official fix(config): update Fibaro fgms001 doc to conform to Fibaro official Dec 7, 2024
@xyanide xyanide changed the title fix(config): update Fibaro fgms001 doc to conform to Fibaro official fix(config): correct Fibaro FGMS001 config to conform to Fibaro official Dec 7, 2024
@xyanide xyanide marked this pull request as draft December 7, 2024 15:16
@xyanide xyanide marked this pull request as ready for review December 7, 2024 15:16
@xyanide xyanide marked this pull request as draft December 7, 2024 15:26
@xyanide xyanide marked this pull request as ready for review December 7, 2024 15:32
Copy link

@manutremo manutremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been having lots of problems with this incorrect file, but the changes to the definitions of the groups seems correct now. Please someone with the correct permissions provide an approving review so it can be merged. Thanks!

@AlCalzone AlCalzone changed the title fix(config): correct Fibaro FGMS001 config to conform to Fibaro official fix(config): correct Fibaro FGMS001 association groups Mar 12, 2025
@AlCalzone AlCalzone enabled auto-merge (squash) March 12, 2025 09:36
@AlCalzone
Copy link
Member

Thanks!

@xyanide xyanide closed this Mar 12, 2025
auto-merge was automatically disabled March 12, 2025 09:39

Pull request was closed

@xyanide xyanide reopened this Mar 12, 2025
@xyanide
Copy link
Contributor Author

xyanide commented Mar 12, 2025

@AlCalzone My bad, I thought I had to merge the PR, but by closing it I disabled the auto merge.
Can you enable auto merge again so the PR can be completed?

@AlCalzone AlCalzone merged commit 28cec93 into zwave-js:master Mar 12, 2025
48 checks passed
AlCalzone added a commit that referenced this pull request Mar 12, 2025
### Config file changes
* Add missing parameters to Qubino Smart Plug 16A (#7409)
* Add missing parameters for the MCO MH-C221 shutter (#7672)
* Correct Fibaro FGMS001 association groups (#7463)
* Add multi-click detection parameter to Zooz ZEN51/52 (#6730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants