Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue #249 and #250 - achieve consistent payoff amount #251

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

wisdant
Copy link
Contributor

@wisdant wisdant commented Oct 17, 2022

Changes included in this PR:

  1. Changed payoff amount calculation so that the user pays exactly the same amount to payoff no matter the amount is used when calling makePayment(). (Issue Actual payoff amount can be different when calling makePayment() with different amounts #249
  2. Changed the behavior related to default. Do not distribute income when setting an account to Defaulted. Do not distribute income for pay periods afterwards as well even if updateDueInfo() is called. The writeoff amount only includes principal at the moment of default. All the payments from the user are applied towards defaulted principals first. Only after the defaulted principals are all paid, the payment will be applied towards the fees&Interest accrued since the moment of default. The account stays in Defaulted state until everything is paid off. (Post-default payment does not work if the payment happened multiple pay periods after the default event #250 )

@wisdant wisdant changed the title Address issue #249 and #250 Address issue #249 and #250 - achieve consistent payoff amount Oct 17, 2022
@PlayJok3r PlayJok3r force-pushed the 60-consistent-payoff-amount branch from b0cd0a2 to a3ab52d Compare October 17, 2022 19:08
Copy link
Contributor

@PlayJok3r PlayJok3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of key changes:

  1. Do not updateDueInfo if already in default state.
  2. Handles payment differently for default borrowers.

@wisdant wisdant merged commit 89292df into master Oct 17, 2022
@wisdant wisdant deleted the 60-consistent-payoff-amount branch October 17, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants