-
Notifications
You must be signed in to change notification settings - Fork 0
chore: fix benchmark tests #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
currently looking at |
prepareProposalRequest := types.RequestPrepareProposal{ | ||
Txs: rawTxs[start:end], | ||
Height: 10, | ||
for start <= end { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworked this test to use a binary search based approach, as I found that when I was running these locally and trying to debug with the upgrade to v0.50 that in some instances the txNum would keep oscillating back and forth and wouldn't be able to hit within the bounds.
It seems to work nice enough now. The benchmark doesn't take quite as long to run, in some random instances it can hit the case where it won't find a ProcessProp time at the target but at least it does not run indefinitely, and running the bench again will normally succeed.
It could probably be further reworked to never hit this, but I didn't want to introduce too many changes. You will never get a deterministic ProcessProp time from what I can see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dope! thanks for fixing these
since the app PR is huge I think simply waiting to merge this would be beneficial, however I'll defer to others if they have a strong opinion
Gives love to benchmarks.
benchmarks
instead of two different onesdeliverTx
->finalizeBlock
Ideally the results.md file could be replaced by some prettified markdown output from the benchmark tests