go diffs

[tac0turtle]

---

PR checklist

• Tests written/updated
• Changelog entry added in .changelog (we use unclog to manage our changelog)
• Updated relevant documentation (docs/ or spec/) and code comments

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "go diffs". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - build
 - chore
 - ci
 - docs
 - refactor
 - perf
 - test
 - revert
 - spec
 - merge

General format: type(scope): msg
Breaking change: type(scope)!: msg
Multi-scope change: type: msg
Types: feat, fix, build, chore, ci, docs, refactor, perf, test, revert, spec, merge.
Example: fix(cmd/cometbft/commands/debug): execute p.Signal only when p is not nil

[evan-forbes]

nice, I haven't see anything that shouldn't have been added!

looks like you were in the process of fixing the diff in how we're handling data https://github.com/celestiaorg/celestia-core/blob/d81b8307a23b0c843b8469f4ba1c84dca86a6fa8/types/block.go#L1014-L1028

core doesn't have the DataRootHash field, the name of which isn't important, but ofc just that we ensure the da root from app is being used everywhere

[tac0turtle]

nice, I haven't see anything that shouldn't have been added!

looks like you were in the process of fixing the diff in how we're handling data https://github.com/celestiaorg/celestia-core/blob/d81b8307a23b0c843b8469f4ba1c84dca86a6fa8/types/block.go#L1014-L1028

core doesn't have the DataRootHash field, the name of which isn't important, but ofc just that we ensure the da root from app is being used everywhere

correct, i saw there was overlap with the existing field in the data of field in comet so i added this to not conflict. ill make sure it works as intended

https://github.com/cometbft/cometbft/blob/main/proto/cometbft/types/v1/types.proto#L79
comet doesnt have the type on the proto, but has it on the struct, you introduced it, so i renamed it to not conflict