Dev/feedstocks review #6

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T09:58:13Z

Purpose of this PR

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

Checklist:

My code follows the coding etiquette
I performed a self-review of my own code
I explained my changes within the PR, particularly in hard-to-understand areas
I checked that the in-code documentation is up-to-date
I adjusted the reporting in remind2 where it was needed
I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

Test runs are here:
Comparison of results (what changes by this PR?):

…mfHxcvx5J7JoaOhFSs5mncnisTJJ6q/remind into feedstocks-emissions

…unting in chemicals subsector

…n/remind-1 into feedstocks-emissions

…tions to the relevant FE carriers, sectors, markets

…gy and chemical process emissions, only temporary purpose

fix subsetting sums of feedstocks implementation to only apply equation to relevant FE carriers, sectors, markets

…n industry

…ic fuels in industry feedstocks

remove feedstock carbon from capture potential and fix declaration of pm_emifacNonEnergy

…l carbon stored in feedstocks from energy emissions as this generates negative emissions

…riers

…that feedstocks in v_demFeNonEnergySector need to be supplied by the energy system, that is, need to be part of vm_demFeSector

…tion of feedstocks, can be deleted once everything checked

- constraint that all feedstocks should be fossil in baseline - add penalty cost to avoid switching between biogenic and synthetic feedstocks between time steps (small fuel switching cost) - subtracting non-fossil (biogenic and synthetic) feedstocks carbon from energy emissions (new form of CDR! -> please discuss with Jess and others!) - correct FE2CES industry demand equation for feedstocks; this forces the model to actuallly supply the amount of biogenic, synthetic, fossil liquids etc. in vm_demFeSector that is used by vm_demFENonEnergySector. Before it was possible that there was, for instance, more bioliquids in vm_demFENonEnergySector than was in the total vm_demFeSector for indst. Eventually I think this should be refactored such that we define indst and indst_feed as two different sectors and only go with one variable, vm_demFeSector and have two different FE2CES balance equations one for indst and one for indst_feed. The current solution is cumbersome but functional. - I added some further parameters in postsolve in industry to check whether the things I was subtracting/adding to various equations actually have the values I wanted them to have. This is just to check whether everything works and can be deleted later on

…remind-1 into feedstocks-updated

…to feedstocks-updated

changes, remove last.dump.rda file

…tor. And clean code

…ict demFENonEnergySector definition to ETS

…tocks-updated

…feedstocks-updated

…ks-updated

…tocks-updated

…ks-updated

…re\datainput.gms

…oaOhFSs5mncnisTJJ6q/remind into michaja-feedstocks-updated and fix sefe() mapping

…lve conflicts, and fix sefe() mapping

…movals

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T09:59:37Z

core/datainput.gms

@@ -1461,6 +1461,40 @@ pm_emifac(ttot,regi,"seliqfos","fehos","tdfoshos","co2") = p_ef_dem(regi,"fehos"
 pm_emifac(ttot,regi,"seliqfos","fepet","tdfospet","co2") = p_ef_dem(regi,"fepet") / (sm_c_2_co2*1000*sm_EJ_2_TWa); !! GtC/TWa
 pm_emifac(ttot,regi,"seliqfos","fedie","tdfosdie","co2") = p_ef_dem(regi,"fedie") / (sm_c_2_co2*1000*sm_EJ_2_TWa); !! GtC/TWa

+***------ Read in emission factors for process emissions in chemicals sector---
+*' calculated using IEA data on feedstocks flows and UNFCCC data on chem sector process emissions
+***TO DO: remove the "*" by modif the input file (fegas instead of gases, etc.)


What exactly is going to be removed? What stays?

I wanted to remove the * here: parameter f_nechem_emissionFactors(ttot,all_regi,*) because I don't know if using that trick is proper coding for us. This means introducing some changes in data preparation in mrremind that I was postponing for the final cleaning before merging. Or can I just leave it like that?

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:00:35Z

core/datainput.gms

+pm_emifacNonEnergy(ttot,regi,'segafos','fegas','indst','co2') = f_nechem_emissionFactors(ttot,regi,"gases") / s_zj_2_twa;
+pm_emifacNonEnergy(ttot,regi,'seliqfos','fehos','indst','co2') = f_nechem_emissionFactors(ttot,regi,"liquids") / s_zj_2_twa;
+pm_emifacNonEnergy(ttot,regi,'sesofos','fesos','indst','co2') = f_nechem_emissionFactors(ttot,regi,"solids") / s_zj_2_twa;
+
+pm_emifacNonEnergy(ttot,regi,'segabio','fegas','indst','co2') = f_nechem_emissionFactors(ttot,regi,"gases") / s_zj_2_twa;
+pm_emifacNonEnergy(ttot,regi,'seliqbio','fehos','indst','co2') = f_nechem_emissionFactors(ttot,regi,"liquids") / s_zj_2_twa;
+pm_emifacNonEnergy(ttot,regi,'sesobio','fesos','indst','co2') = f_nechem_emissionFactors(ttot,regi,"solids") / s_zj_2_twa;
+
+pm_emifacNonEnergy(ttot,regi,'segasyn','fegas','indst','co2') = f_nechem_emissionFactors(ttot,regi,"gases") / s_zj_2_twa;
+pm_emifacNonEnergy(ttot,regi,'seliqsyn','fehos','indst','co2') = f_nechem_emissionFactors(ttot,regi,"liquids") / s_zj_2_twa;


Use double quotes, as per coding style.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:02:14Z

core/declarations.gms

 pm_omeg (all_regi,opTimeYr,all_te)                          "technical depreciation parameter, gives the share of a capacity that is still usable after tlt. [none/share, value between 0 and 1]"
 p_aux_lifetime(all_regi,all_te)                             "auxiliary parameter for calculating life times, calculated externally in excel sheet"
 pm_pedem_res(ttot,all_regi,all_te)                          "Demand for pebiolc residues, needed for enhancement of residue potential [TWa]"
 p_ef_dem(all_regi,all_enty)                                 "Demand side emission factor of final energy carriers [MtCO2/EJ]"

+*** share of plastic waste that is incinerated REDUNDANT; DELETE ME


Tip: use one marker comment (like FIXME or TODO) and describe what to change. You have at least DELETE ME and TO DO. Good luck remembering and finding all of them.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:14:12Z

core/declarations.gms

+vm_FeedstocksCarbon(ttot,all_regi,all_enty,all_enty,all_emiMkt)             "carbon contained in chemical feedstocks [GtC]"
+vm_plasticsCarbon(ttot,all_regi,all_enty,all_enty,all_emiMkt)               "carbon contained in plastics [GtC]"
+vm_feedstockEmiUnknownFate(ttot,all_regi,all_enty,all_enty,all_emiMkt)      "carbon contained in plastics with unknown fate (assumed to go back into the atmosphere) [GtC]"
+vm_incinerationEmi(ttot,all_regi,all_enty,all_enty,all_emiMkt)              "Emissions from incineration of plastic waste [GtC]"
+vm_nonIncineratedPlastics(ttot,all_regi,all_enty,all_enty,all_emiMkt)       "carbon contained in plastics that are not incinerated [GtC]"


This could use a little more rigour in the naming and describing. Five variables, that are all defined over the same sets -- notably all_emiMkt, so they all look like emissions.

And it is not apparent what the different fates of plastics are. They can be incinerated, they can not be incinerated (that is landfilled?), and is there something else happening to them (unknown). or is there some part of plastics for which we do not know what happens to them?

ups yeah, one description is wrong. I'll extend them so it's more clear

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:16:42Z

core/equations.gms

+        vm_nonIncineratedPlastics(t,regi,entySe,entyFe,emiMkt)
+      )
+    )$( sameas(enty,"co2") )
+    !! add emissions from plastics incineration. CHECK FOR DOUBLE-COUNTING RISK


Another instance where FIXME would have been safer.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:22:57Z

modules/02_welfare/utilitarian/postsolve.gms

+        v02_NegInconvPenNonEnSwitch.l(t,regi,entySe,entyFe,sector,emiMkt)
+      + v02_NegInconvPenNonEnSwitch.l(t,regi,entySe,entyFe,sector,emiMkt)


As above: why is this two times the negative variable, not positive and negative?

I'm running tests now to investigate the effect of fixing this mistake

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:23:24Z

modules/02_welfare/utilitarian/postsolve.gms

+        v02_NegInconvPenNonEnSwitch.l(t,regi,entySe,entyFe,sector,emiMkt)
+      + v02_NegInconvPenNonEnSwitch.l(t,regi,entySe,entyFe,sector,emiMkt)
+      )
+    / 1e3


Again, where does the magic number come from?

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:28:03Z

modules/37_industry/subsectors/sets.gms

@@ -198,6 +198,13 @@ $endif.process_based_steel
                      feh2_otherInd, fehe_otherInd, feelhth_otherInd)
  /

+  in_chemicals_37(all_in)   "chemicals FE that can provide feedstocks"


A more descriptive name would be welcome. Somebody sometime will mistake this for all the production factors in the chemicals subsector.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:29:14Z

modules/37_industry/subsectors/sets.gms

  /
    fesos
    fehos
    fegas
  /

+entySE_emiFac_feedstocks(all_enty,all_enty) "SE type of emissions factor that should be used to calculate carbon contained in feedstocks"


Appears to be unused.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q · 2023-09-13T10:34:03Z

modules/37_industry/subsectors/equations.gms

+*** carriers, no biofuels or synfuels
+q37_FossilFeedstock_Base(t,regi,entyFE,emiMkt)$(
+                         entyFE2sector2emiMkt_NonEn(entyFE,"indst",emiMkt)
+                     AND cm_emiscen eq 1                                   ) ..


Not sure if that is (still) sufficient, ince we more or less replaced baseline by NPi.
Should this be the case for NPi runs, too?
See remindmodel#1342.

Reworked `checkClimatePercentiles.R`

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q and others added 30 commits October 12, 2021 15:31

add lower bound on feso/feli/fega in chemicals FE input for feedstocks

6086222

Merge branch 'dev/chemicals_feedstock_share' of https://github.com/0U…

4c646c6

…mfHxcvx5J7JoaOhFSs5mncnisTJJ6q/remind into feedstocks-emissions

adds a factor to discount (non-energy) feedstocks from emissions acco…

3b4dda1

…unting in chemicals subsector

Merge branch 'remindmodel:develop' into feedstocks-emissions

d787eb6

Please enter the commit message for your changes. Lines starting

82081ae

Merge branch 'feedstocks-emissions' of https://github.com/mellamoSimo…

8c7f07c

…n/remind-1 into feedstocks-emissions

debug mappings in non-energy feedstock flows 2(gitshow)

576be8b

add emissions from non-energy feedstocks in the chemicals sector

8833a78

fix subsetting of sums of feedstocks implementation to only apply equ…

f093da3

…tions to the relevant FE carriers, sectors, markets

add some parameters for checking the newly introduced FE w/o non-ener…

b6da625

…gy and chemical process emissions, only temporary purpose

Merge pull request #1 from fschreyer/feedstocks-emissions

374064e

fix subsetting sums of feedstocks implementation to only apply equation to relevant FE carriers, sectors, markets

remove feedstock carbon in industry from carbon that can be captured

3c8d6ef

initialize pm_emifacNonEnergy for all years via ttot

c20ec68

minor description update

f701461

add constraint that baseline runs should only use fossil feedstocks i…

6d27211

…n industry

add small penalty cost on fuel switching between biogenic and synthet…

cf5e671

…ic fuels in industry feedstocks

Merge pull request #2 from fschreyer/feedstocks-emissions

d5c0d05

remove feedstock carbon from capture potential and fix declaration of pm_emifacNonEnergy

correct emissions accounting of feedstock carbon: substract non-fossi…

c5fa360

…l carbon stored in feedstocks from energy emissions as this generates negative emissions

correct entySeSyn set to contain only synthetic liquids, gases SE car…

2baede0

…riers

correct FE2CES industry balance equation for feedstocks supply, such …

f5698a2

…that feedstocks in v_demFeNonEnergySector need to be supplied by the energy system, that is, need to be part of vm_demFeSector

add futher parameters in industry module to check correct implementa…

f5b9a66

…tion of feedstocks, can be deleted once everything checked

clean up the code a bit

fd19be3

Merge branch 'feedstocks-emissions' into feedstocks-emissions

eaee352

resolve conflicts with main trunk

eafe50c

Merge branch 'remindmodel:develop' into feedstocks-updated

d7dba4d

Merge branch 'remindmodel:develop' into feedstocks-updated

f7786ef

fix remaining conflict

1bed621

Merge branch 'feedstocks-updated' of https://github.com/mellamoSimon/…

fe3617c

…remind-1 into feedstocks-updated

Merge branch 'develop' of https://github.com/mellamoSimon/remind-1 in…

3518dbb

…to feedstocks-updated

mellamoSimon and others added 26 commits August 2, 2022 11:45

add section break for feedstock balances

aeb68e9

clean up industry code, remove entySe2entyFe set, reset main.gms

2d23164

changes, remove last.dump.rda file

Merge branch 'remindmodel:develop' into feedstocks-updated

637280e

delete canceling terms in main balance of industry/subsectors

76598cd

fix file ending

8ad444d

read in regionalized emission factors for feedstocks in chemicals sec…

0b5d50c

…tor. And clean code

fixes to read in feedstocks emissions data

cfb93d4

fix sets in q37_demFeFeedstockChemIndst that calculates feedstocks

dfd92b0

define feedstocks emi factors for synfuels and biofuels too and restr…

39296c3

…ict demFENonEnergySector definition to ETS

fix conflicts with develop branch

2722c76

Merge branch 'develop' of github.com:mellamoSimon/remind-1 into feeds…

6d426a8

…tocks-updated

Merge branch 'develop' of github.com:mellamoSimon/remind-1 into feeds…

ace0c5a

…tocks-updated

Merge branch 'develop' of github.com:mellamoSimon/remind-1 into feeds…

b3dc515

…tocks-updated

Merge branch 'develop' of https://github.com/remindmodel/remind into …

66713eb

…feedstocks-updated

littel message for clean up

a6819d4

Merge branch 'develop' of github.com:remindmodel/remind into feedstoc…

a17adfa

…ks-updated

Merge branch 'develop' of github.com:mellamoSimon/remind-1 into feeds…

c7acd43

…tocks-updated

Merge branch 'develop' of github.com:remindmodel/remind into feedstoc…

fe1df9e

…ks-updated

fix path to input file with emissions factors for chemical processes

39b0d27

add feedstock emi factors file to core\input\files and fix path in co…

a4fc992

…re\datainput.gms

modify paths for internal testing

ab3813c

Merge branch 'feedstocks-updated' of https://github.com/0UmfHxcvx5J7J…

a24287c

…oaOhFSs5mncnisTJJ6q/remind into michaja-feedstocks-updated and fix sefe() mapping

Merge branch 'michaja-feedstocks-updated' into feedstocks-updated, so…

8b6a7aa

…lve conflicts, and fix sefe() mapping

UNFINISHED: add plastics incineration emissions and plastic carbon re…

9aa92ef

…movals

bugfix incineration of plastics

9019040

boyscout readability

3573494

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented Sep 13, 2023

View reviewed changes

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q closed this Dec 19, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q deleted the dev/feedstocks-review branch December 19, 2023 16:11

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q pushed a commit that referenced this pull request Sep 5, 2024

Merge pull request #6 from tonnrueter/dev/checkclimate

7c08fe6

Reworked `checkClimatePercentiles.R`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev/feedstocks review #6

Dev/feedstocks review #6

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented Sep 13, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

mellamoSimon Sep 19, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

mellamoSimon Sep 19, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

mellamoSimon Sep 19, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

mellamoSimon Sep 19, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q Sep 13, 2023

		v02_NegInconvPenNonEnSwitch.l(t,regi,entySe,entyFe,sector,emiMkt)
		+ v02_NegInconvPenNonEnSwitch.l(t,regi,entySe,entyFe,sector,emiMkt)

Dev/feedstocks review #6

Dev/feedstocks review #6

Conversation

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented Sep 13, 2023

Purpose of this PR

Type of change

Checklist:

Further information (optional):

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment