Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add open api for account info. #21

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Add open api for account info. #21

merged 2 commits into from
Apr 17, 2024

Conversation

Argeric
Copy link
Contributor

@Argeric Argeric commented Apr 16, 2024

Add account information API which returns the statistical information of the files uploaded by the user and the balance of layer1.


This change is Reviewable

@Argeric Argeric requested a review from boqiu April 16, 2024 06:36
Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Argeric)


api/account_api.go line 43 at r1 (raw file):

	if accountInfo.TxCount > 0 {
		accountInfo.TxTab = 1

Why not return count info directly?

@Argeric
Copy link
Contributor Author

Argeric commented Apr 16, 2024

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Argeric)

api/account_api.go line 43 at r1 (raw file):

	if accountInfo.TxCount > 0 {
		accountInfo.TxTab = 1

Why not return count info directly?

Fixed. Return count info instead of display flag.

@Argeric Argeric requested a review from boqiu April 16, 2024 07:37
Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Argeric)

@Argeric Argeric merged commit 6637766 into main Apr 17, 2024
2 checks passed
@Argeric Argeric deleted the account-info-api branch April 17, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants