Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo causing complex string parsing to fail on subsequent runs #31

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Aug 24, 2024

Resolve 0no-co/gql.tada#379

Summary

This causes "\\" escape sequences in strings to not be detected the second time around, since lastIndex doesn't reset due to the typo of g added to the regex.

Set of changes

  • Fix stateful regex check

Copy link

changeset-bot bot commented Aug 24, 2024

🦋 Changeset detected

Latest commit: 5608597

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@0no-co/graphql.web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Fix typo causing complex string detection not to trigger
correctly.
@kitten kitten force-pushed the fix/complex-string-detection branch from 88a29d7 to 5608597 Compare August 24, 2024 10:33
@kitten kitten merged commit a7e16e5 into main Aug 24, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphql() function duplicates backslashes in query
2 participants