Introduce sanitize_va() & has_prefix() for VA formatting

[yourpwnguy]

Summary

This PR introduces two new utility functions, sanitize_va() and has_prefix(), to handle and properly format virtual addresses (VA), particularly when copied from WinDbg.

Changes

• Added has_prefix()

  • Checks if a virtual address string starts with "0x" or "0X".
  • Also, prevents redundant prefixing in sanitization logic.

• Added sanitize_va()

  • Removes backticks ('`') from VA strings (WinDbg formatting) ( Ex: 00007ff7`89da0000 )
  • Ensures "0x" prefix is added if missing.

• Optimised get_file_size()

  • Optimized to avoid unnecessary checks and modifications.

[0vercl0k]

@yourpwnguy please try this out; if this works for you I'll get this merged.

Cheers

[yourpwnguy]

@0vercl0k It seems fine and works correctly! You can merge it after checking my comment on the va_to_integer function regarding erase(). Not a necessary change, just an observation.

Cheers!

[0vercl0k]

Where is this comment @yourpwnguy I can't seem to find it 😅

[yourpwnguy]

@0vercl0k Oh, I actually meant for you to check the text under review, my bad! 😅 I'll make sure to be clearer next time.

[0vercl0k]

I don't seem to see anything on my side; unless I'm missing something 🤔

[0vercl0k]

Do you mind pasting it here so that I can have a look before merging please?

[yourpwnguy]

I see, maybe it's on my side. I will just comment the text here.

I noticed that when using *it = '\0';, calling va.size() just after it still returns the original size, which might be misleading for debugging or if va was used elsewhere.

Using va.erase(it, va.end()); correctly updates the size. That said, since va is only used within this function and passed directly to strtoull(), it doesn’t actually matter in this case, just mentioning it in case it’s relevant.

test