Delete mockgen mocks #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project has several mockgen mocks and a build step that auto-updates them on each build, but they appear to be unused, so this PR deletes them.
|
Are these mocks serving a purpose I'm overlooking? If not, it seems better to delete them and eliminate a build step and code clutter. |
|
Thanks. They were used in early versions for unit testing. |
mtlynch
added a commit
to mtlynch/fusion
that referenced
this pull request
Dec 30, 2024
I forgot to remove it as part of 0x2E#39, but this is dead code now and is just a no-op since there's no more go:generate directives in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project has several mockgen mocks and a build step that auto-updates them on each build, but they appear to be unused, so this PR deletes them.