Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes and DevEx improvements. #14

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wkpatrick
Copy link

@wkpatrick wkpatrick commented Jan 1, 2025

I don't expect all of this PR to make it in, this is mostly just a collection of fixes and developer experience improvements.

Fixes

  • aviansie got renamed.
  • Add try/catch statements around the builder loops. This way a bad article only affects itself, and not everything after it.
  • Remove bare exception I added in wiki_page_text.py

Developer Experience Improvements

  • Switch to using uv for fetching deps and handling the venvs
  • Add mise for handling python installation and task running. It directly integrates with uv so it automatically switches to the venv when you enter the folder. This previously would also include a jdk installation, but this is no longer needed.
  • Add a group of mise tasks that roughly map with the old update scripts. Easier to run and edit, and importantly will notify you of errors when one of the tasks errors out, instead of moving on to the next one (I think this is responsible for a bunch of new content not being added lately, especially with leagues and the temp items being around.
  • Use a python script to download the latest pre-dumped caches from abex's github and extract it. This means we no longer need jdk/runlite in the project builder.

Let me know if you only want parts of this merged in, and I can make a new PR with just the changes you want. At least for me, ill be keeping all of it around.

@wkpatrick wkpatrick changed the title Mise Various Fixes and DevEx improvements. Jan 1, 2025
@OSRSKoeppy
Copy link

@0xNeffarion I was wondering if you could take a look at @wkpatrick PR?

Just was browsing through and I know we were using the data you are collecting for our runelite plugin but a handful of NPCs seem to be missing what drops they can give.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants