Open
Conversation
- Fix typos across the tutorial - Fix some grammar and punctuation - Fix the issue of using decimal numbers in the example smart contract which was causing compiling issues - Apply the concept of basis points to work with percentages in the smart contract and adjusted codebase - Add a note that helps users to find the code for the AggregatorV3 Interface - Add configure settings for Hardhat in the deployment section - Add the requirements section to let users know what tools they should have to follow the tutorial smoothly - Add a pre-requisites section to allow users to know what they should know to be able to follow the tutorial without any issues - Fix the title of the tutorial for best practices - Add links and references to technologies or concepts mentioned in the tutorial - Improve documentation of both smart contract - Add a modifier that ensures the arguments for the `amount` parameter are valid values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amountparameter are valid valuesSetting Up Your Development Environmentexplanation to improve readability.Observations
_calculateStabilityfunction as currently it's a bit confusing.